Add migration for TSModuleDeclaration AST change #3021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for babel-next ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for babel ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
liuxingbaoyu
approved these changes
Dec 4, 2024
|
|
||
| Rather than representing `namespace X.Y {}` as two nested `TSModuleDeclaration` nodes with names `X` and `Y`, | ||
| it is not represented as a single `TSModuleDeclaration` whose name is a `TSQualifiedName(X, Y)`. This change | ||
| aligns the AST with `@typescript-eslint`. parser. |
JLHwung
reviewed
Dec 4, 2024
| - Use `TSQualifiedName` for `namespace X.Y {}`'s name ([#16982](https://github.com/babel/babel/pull/16982)) | ||
|
|
||
| Rather than representing `namespace X.Y {}` as two nested `TSModuleDeclaration` nodes with names `X` and `Y`, | ||
| it is not represented as a single `TSModuleDeclaration` whose name is a `TSQualifiedName(X, Y)`. This change |
There was a problem hiding this comment.
Suggested change
| it is not represented as a single `TSModuleDeclaration` whose name is a `TSQualifiedName(X, Y)`. This change | |
| it is now represented as a single `TSModuleDeclaration` whose name is a `TSQualifiedName(X, Y)`. This change |
|
|
||
| Rather than representing `namespace X.Y {}` as two nested `TSModuleDeclaration` nodes with names `X` and `Y`, | ||
| it is not represented as a single `TSModuleDeclaration` whose name is a `TSQualifiedName(X, Y)`. This change | ||
| aligns the AST with `@typescript-eslint`. parser. |
There was a problem hiding this comment.
Suggested change
| aligns the AST with `@typescript-eslint`. parser. | |
| aligns the AST with the `@typescript-eslint` parser. |
| @@ -204,6 +237,24 @@ Check out the [v8-migration guide](v8-migration.md) for other user-level changes | |||
| } | |||
| ``` | |||
|
|
|||
| - The second argument (`body`) of `TSModuleDeclaration` cannot be a `TSModuleDeclaration` anymore ([#16982](https://github.com/babel/babel/pull/16982)) | |||
There was a problem hiding this comment.
Suggested change
| - The second argument (`body`) of `TSModuleDeclaration` cannot be a `TSModuleDeclaration` anymore ([#16982](https://github.com/babel/babel/pull/16982)) | |
| - The second argument (`body`) of `t.tsModuleDeclaration` cannot be a `TSModuleDeclaration` node anymore ([#16982](https://github.com/babel/babel/pull/16982)) |
| t.tsModuleBlock([]) | ||
| - ) | ||
| ) | ||
| ``` |
There was a problem hiding this comment.
I would expect there are two examples here since we have mentioned two migration approaches. This example seems to be of the second one. Could you add an example for the first approach?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docs for babel/babel#16982