trie: parallel insert trie when root node is a full node #597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This creates a new TryBatchInsert function in trie. All key-value insertion
pairs are passed together. If the resolved root node is a full node, the
insertion pairs are partitioned by the first byte in their keys. Children
subtries of the full node are inserted in parallel. If the resolved root node is
not a full node, the insertion pairs are inserted sequentially.
Result comparing BenchmarkNormalInsert to BenchmarkBatchInsert
goos: linux
goarch: amd64
pkg: github.com/ethereum/go-ethereum/trie
cpu: 11th Gen Intel(R) Core(TM) i7-1165G7 @ 2.80GHz
│ normal.txt │ batch.txt │
│ sec/op │ sec/op vs base │
NormalInsert-8 6.823m ± 7% 3.716m ± 18% -45.54% (p=0.000 n=10)
minh-bq
force-pushed
the
parallel-insert-trie
branch
3 times, most recently
from
8f1f1e4 to
0fe75e8
Compare
When there are more than parallelInsertThreshold (currently set to 500) pending storages update to storage trie, we will use the new TryBatchInsert to parallel insert these storages if possible.
This benchmark is intended to be used with mainnet data. The benchmark includes many storage updates to Axie contract's storage.
minh-bq
force-pushed
the
parallel-insert-trie
branch
from
0fe75e8 to
a795205
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates a new TryBatchInsert function in trie. All key-value insertion
pairs are passed together. If the resolved root node is a full node, the
insertion pairs are partitioned by the first byte in their keys. Children
subtries of the full node are inserted in parallel. If the resolved root node is
not a full node, the insertion pairs are inserted sequentially.