Skip to content

Issues: attestate/libharberger

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

13 Open 24 Closed
13 Open 24 Closed
Author
Filter by author
Loading
Label
Filter by label
Loading
Use alt + click/return to exclude labels
or ⇧ + click/return for logical OR
Projects
Filter by project
Loading
Milestones
Filter by milestone
Loading
Assignee
Filter by who’s assigned
Sort
Sort by
Newest Oldest Most commented Least commented Recently updated Least recently updated Best match
Most reactions
👍 👎 😄 🎉 😕 ❤️ 🚀 👀

Issues list

Implement https://eips.ethereum.org/EIPS/eip-4907
#37 opened Jul 9, 2022 by TimDaub
@TimDaub
Allowing to set tax rate by beneficiary allows to artificially increase rate without potentially being noticed
#36 opened Apr 7, 2022 by TimDaub
before changing taxrate with setTaxRate, it should be settled with collateral
#35 opened Apr 7, 2022 by TimDaub
@TimDaub
for testFail tests, match message with expectrevert
#34 opened Apr 3, 2022 by TimDaub
Run a gas benchmark on all external/public functions
#33 opened Apr 3, 2022 by TimDaub
Make sure an external application can replicate all state through events
#32 opened Apr 3, 2022 by TimDaub Minor version bump
@TimDaub
introduce tax struct
#31 opened Apr 3, 2022 by TimDaub
@TimDaub
consider moving _settleAssessment's transfers to the very end of buy and topup (to avoid risk of reentrancy)
#28 opened Apr 3, 2022 by TimDaub
@TimDaub
find a way to consistently order function modifiers (e.g. such that payable is always last etc.)
#27 opened Apr 3, 2022 by TimDaub
@TimDaub
Add Topup and withdraw events to interface
#24 opened Apr 3, 2022 by TimDaub Minor version bump
@TimDaub
Adjust "Usage" section in readme.md with example of using PluralProperty class
#23 opened Apr 3, 2022 by TimDaub Minor version bump
Allow pricing property with ERC20 tokens; specifically to allow pricing in USD with stable coins
#18 opened Apr 3, 2022 by TimDaub
@TimDaub
seek consistency with naming function inputs
#13 opened Mar 24, 2022 by TimDaub
@TimDaub
ProTip! Add no:assignee to see everything that’s not assigned.