Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify hal_(doc|build)_variants properties #677

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

glaeqen
Copy link
Contributor

@glaeqen glaeqen commented Mar 7, 2023

No description provided.

@glaeqen glaeqen changed the title Unify hal_(doc|build)_properties Unify hal_(doc|build)_variants properties Mar 7, 2023
@glaeqen glaeqen force-pushed the missing-doc-variants branch from c4682c3 to 1af4c81 Compare March 7, 2023 14:48
@glaeqen glaeqen mentioned this pull request Mar 7, 2023
@jbeaurivage jbeaurivage added the enhancement New feature or request label May 14, 2023
@jbeaurivage
Copy link
Contributor

@glaeqen, if you want to sync this branch to master, I'll be happy to merge.

@glaeqen
Copy link
Contributor Author

glaeqen commented Oct 22, 2024

Hey, I must say that I got a little out of a loop with atsamd. I tried to rebase it once a few months ago but had a hard time understanding a new feature system. So my motivation somewhat waned 😅 Could try again though.

Edit: oh wait, this is not a timer PR, forgot about that this one. I'll try to get to it soon

@glaeqen glaeqen force-pushed the missing-doc-variants branch from 1af4c81 to 2006509 Compare October 27, 2024 15:30
@glaeqen
Copy link
Contributor Author

glaeqen commented Oct 27, 2024

generate-docs.yml workflow should be exercised first before we can say this is mergable.

@sajattack
Copy link
Member

generate-docs.yml workflow should be exercised first before we can say this is mergable.

hmm, can you try it on a fork? I think if I do it here it will push and maybe mess up prod?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants