Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PAC for ATSAML22J18A #663

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

tahnok
Copy link

@tahnok tahnok commented Jan 9, 2023

Very WIP, just want to put this up early to check if this would be accepted at all for this particular chip. Can someone confirm? If yes I'll clean up this PR, see if I can actually build it, etc...

Initial commit of svd2rust for the ATSAML22J18A. Had to modify the SYNCBUSY register definition by hand so that each clock had 1 bit.

Summary

[describe your changes here]

Checklist

  • CHANGELOG.md for the BSP or HAL updated
  • All new or modified code is well documented, especially public items
  • No new warnings or clippy suggestions have been introduced (see CI or check locally)

If Adding a new Board

  • Board CI added to crates.json
  • Board is properly following "Tier 2" conventions, unless otherwise decided to be "Tier 1"

If Adding a new cargo feature to the HAL

  • Feature is added to the test matrix for applicable boards / PACs in crates.json

Initial commit of svd2rust for the ATSAML22J18A. Had to modify the
SYNCBUSY register definition by hand so that each clock had 1 bit
@bradleyharden
Copy link
Contributor

@tahnok, I think we're open to the idea of supporting more chips, but we've also been short on maintainers lately. This is also the second request to support another chip in just a few days (see #659 and #662). It also comes as I'm trying to port #450 to our other chips, and this is just adding to that effort. We'll have to evaluate and see.

@TethysSvensson
Copy link
Contributor

@bradleyharden How is the workload on the maintainers these days? Would you be interested in accepting this now if this was a bit more finished?

@sajattack
Copy link
Member

How is the workload on the maintainers these days? Would you be interested in accepting this now if this was a bit more finished?

we're still stretched pretty thin I would say.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants