Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOLR-17306: fix replication problem on follower restart #2874

Closed
wants to merge 0 commits into from

Conversation

ds-manzinger
Copy link

@ds-manzinger ds-manzinger commented Nov 19, 2024

https://issues.apache.org/jira/browse/SOLR-17306

Same as #2873 -> but now against main branch

Description

If Leader has Replication disabled - do not delete Followers data on restart

Solution

Check if Leader Replication is enabled

Tests

Implemented Unit Tests, that check different restart scenarios. Enable Directory Storage for Replica, othwerwise tests will not work because memory is cleaned on restart

Checklist

Please review the following and check all that apply:

  • I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
  • I have created a Jira issue and added the issue ID to my pull request title.
  • I have given Solr maintainers access to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation)
  • I have developed this patch against the main branch.
  • I have run ./gradlew check.
  • I have added tests for my changes.
  • I have added documentation for the Reference Guide

@ds-manzinger
Copy link
Author

Is there anybody reviewing that PR?

Copy link
Contributor

@epugh epugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had started a review, and never finished it!

@epugh
Copy link
Contributor

epugh commented Dec 17, 2024

I tried to push latest main updates to the branch, but i don't have permissions to push to your branch... Could you update and add a CHANGES.txt entry? Using the "via Eric Pugh" style and then I'll merge and back port.

@epugh
Copy link
Contributor

epugh commented Dec 18, 2024

@ds-manzinger I just went to merge, and of course my old enemy, CHANGES.txt has merge conflict. Would you mine fixing that and then I'll click the merge button! Lookign forward to getting this in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants