Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Multi-stage] Reduce PinotQuery copy #14669

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Jackie-Jiang
Copy link
Contributor

Only make PinotQuery deep copy when both OFFLINE and REALTIME table are queried at leaf stage.

@Jackie-Jiang Jackie-Jiang added enhancement multi-stage Related to the multi-stage query engine labels Dec 16, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 92.68293% with 3 lines in your changes missing coverage. Please review.

Project coverage is 64.06%. Comparing base (59551e4) to head (38c6f7b).
Report is 1478 commits behind head on master.

Files with missing lines Patch % Lines
...ry/runtime/plan/server/ServerPlanRequestUtils.java 92.68% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #14669      +/-   ##
============================================
+ Coverage     61.75%   64.06%   +2.31%     
- Complexity      207     1605    +1398     
============================================
  Files          2436     2703     +267     
  Lines        133233   148925   +15692     
  Branches      20636    22821    +2185     
============================================
+ Hits          82274    95413   +13139     
- Misses        44911    46519    +1608     
- Partials       6048     6993     +945     
Flag Coverage Δ
custom-integration1 100.00% <ø> (+99.99%) ⬆️
integration 100.00% <ø> (+99.99%) ⬆️
integration1 100.00% <ø> (+99.99%) ⬆️
integration2 0.00% <ø> (ø)
java-11 63.97% <92.68%> (+2.26%) ⬆️
java-21 63.94% <92.68%> (+2.31%) ⬆️
skip-bytebuffers-false 64.06% <92.68%> (+2.31%) ⬆️
skip-bytebuffers-true 63.85% <92.68%> (+36.12%) ⬆️
temurin 64.06% <92.68%> (+2.31%) ⬆️
unittests 64.06% <92.68%> (+2.31%) ⬆️
unittests1 56.33% <92.68%> (+9.44%) ⬆️
unittests2 34.49% <0.00%> (+6.75%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jackie-Jiang Jackie-Jiang force-pushed the reduce_pinot_query_copy branch from 994c33b to 68293b0 Compare December 17, 2024 00:18
@Jackie-Jiang Jackie-Jiang force-pushed the reduce_pinot_query_copy branch from 68293b0 to 38c6f7b Compare December 17, 2024 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement multi-stage Related to the multi-stage query engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants