FIX When the namespace does not exist, it is still possible to create configuration items #12890

fuhouyu · 2024-11-23T05:49:27Z

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

resolve #12889
FIX When the namespace does not exist, configuration items can still be created.

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

…nfig

github-actions · 2024-11-23T05:49:40Z

Thanks for your this PR. 🙏
Please check again for your PR changes whether contains any usage/api/configuration change such as Add new API , Add new configuration, Change default value of configuration.
If so, please add or update documents(markdown type) in docs/next/ for repository nacos-group/nacos-group.github.io

感谢您提交的PR。 🙏
请再次查看您的PR内容，确认是否包含任何使用方式/API/配置参数的变更，如：新增API、新增配置参数、修改默认配置等操作。
如果是，请确保在提交之前，在仓库nacos-group/nacos-group.github.io中的docs/next/目录下添加或更新文档（markdown格式）。

codecov-commenter · 2024-11-23T06:32:53Z

Codecov Report

Attention: Patch coverage is 4.76190% with 20 lines in your changes missing coverage. Please review.

Project coverage is 72.26%. Comparing base (cb3685d) to head (1975f3a).

Files with missing lines	Patch %	Lines
...aba/nacos/core/utils/NamespaceParamCheckUtils.java	0.00%	12 Missing ⚠️
...a/nacos/common/paramcheck/DefaultParamChecker.java	20.00%	3 Missing and 1 partial ⚠️
...baba/nacos/core/paramcheck/ParamCheckerFilter.java	0.00%	2 Missing ⚠️
...nacos/core/remote/grpc/RemoteParamCheckFilter.java	0.00%	2 Missing ⚠️

Additional details and impacted files

@@              Coverage Diff              @@
##             develop   #12890      +/-   ##
=============================================
- Coverage      72.29%   72.26%   -0.03%     
- Complexity      9930     9932       +2     
=============================================
  Files           1302     1303       +1     
  Lines          41751    41770      +19     
  Branches        4392     4396       +4     
=============================================
+ Hits           30182    30185       +3     
- Misses          9461     9477      +16     
  Partials        2108     2108

Files with missing lines	Coverage Δ
.../nacos/common/paramcheck/AbstractParamChecker.java	`100.00% <ø> (ø)`
...baba/nacos/core/paramcheck/ParamCheckerFilter.java	`20.93% <0.00%> (-0.50%)`	⬇️
...nacos/core/remote/grpc/RemoteParamCheckFilter.java	`0.00% <0.00%> (ø)`
...a/nacos/common/paramcheck/DefaultParamChecker.java	`96.84% <20.00%> (-1.78%)`	⬇️
...aba/nacos/core/utils/NamespaceParamCheckUtils.java	`0.00% <0.00%> (ø)`

... and 1 file with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb3685d...1975f3a. Read the comment docs.

wuyfee · 2024-11-23T06:48:36Z

$\color{red}{FAILURE}$
DETAILS
✅ - docker: success
✅ - deploy (standalone & cluster & standalone_auth): success
✅ - e2e-java-test (standalone & cluster & standalone_auth): success
❌ - e2e-go-test (standalone & cluster): failure
❌ - e2e-cpp-test (standalone & cluster): failure
✅ - e2e-csharp-test (standalone & cluster): success
❌ - e2e-nodejs-test (standalone & cluster): failure
❌ - e2e-python-test (standalone & cluster): failure
✅ - clean (standalone & cluster & standalone_auth): success

shiyiyue1102 · 2024-11-26T07:31:28Z

it will be better to extract empty tenant checking to a filter both on http and grpc.
empty tenant checking should be light-weighting，we can't invoke persist operation through get config interface.
considering upgrade compatibility for the current

fuhouyu · 2024-11-26T09:55:54Z

it will be better to extract empty tenant checking to a filter both on http and grpc.

empty tenant checking should be light-weighting，we can't invoke persist operation through get config interface.

considering upgrade compatibility for the current
OK, thank you teacher. I'll look at how to extract this verification logic to the filter later.

shiyiyue1102 · 2024-11-27T10:21:19Z

@fuhouyu would you please fix namespace existing checking on naming module together on this pr ?

fuhouyu · 2024-11-27T13:02:23Z

@fuhouyu would you please fix namespace existing checking on naming module together on this pr ?

Ok, I will move the logic of this empty tenant check to the naming module over the weekend

fuhouyu · 2024-11-30T10:32:33Z

@fuhouyu would you please fix namespace existing checking on naming module together on this pr ?

I see that the parameter validation in the code is placed in the core module, so the validation logic of this namespace is placed under the remoteFilter and paramFilter in the core module.
Please teacher check the code, thank you teacher.

wuyfee · 2024-11-30T10:32:37Z

$\color{red}{FAILURE}$
DETAILS
✅ - docker: success
✅ - deploy (standalone & cluster & standalone_auth): success
❌ - e2e-java-test (standalone & cluster & standalone_auth): failure
❌ - e2e-go-test (standalone & cluster): failure
✅ - e2e-cpp-test (standalone & cluster): success
❌ - e2e-csharp-test (standalone & cluster): failure
✅ - e2e-nodejs-test (standalone & cluster): success
✅ - e2e-python-test (standalone & cluster): success
✅ - clean (standalone & cluster & standalone_auth): success

wuyfee · 2024-11-30T11:04:05Z

$\color{red}{FAILURE}$
DETAILS
✅ - docker: success
✅ - deploy (standalone & cluster & standalone_auth): success
❌ - e2e-java-test (standalone & cluster & standalone_auth): failure
❌ - e2e-go-test (standalone & cluster): failure
✅ - e2e-cpp-test (standalone & cluster): success
❌ - e2e-csharp-test (standalone & cluster): failure
✅ - e2e-nodejs-test (standalone & cluster): success
✅ - e2e-python-test (standalone & cluster): success
✅ - clean (standalone & cluster & standalone_auth): success

wuyfee · 2024-11-30T11:23:01Z

$\color{red}{FAILURE}$
DETAILS
✅ - docker: success
✅ - deploy (standalone & cluster & standalone_auth): success
❌ - e2e-java-test (standalone & cluster & standalone_auth): failure
✅ - e2e-go-test (standalone & cluster): success
✅ - e2e-cpp-test (standalone & cluster): success
✅ - e2e-csharp-test (standalone & cluster): success
✅ - e2e-nodejs-test (standalone & cluster): success
✅ - e2e-python-test (standalone & cluster): success
✅ - clean (standalone & cluster & standalone_auth): success

wuyfee · 2024-11-30T11:54:37Z

$\color{red}{FAILURE}$
DETAILS
✅ - docker: success
✅ - deploy (standalone & cluster & standalone_auth): success
❌ - e2e-java-test (standalone & cluster & standalone_auth): failure
✅ - e2e-go-test (standalone & cluster): success
✅ - e2e-cpp-test (standalone & cluster): success
✅ - e2e-csharp-test (standalone & cluster): success
✅ - e2e-nodejs-test (standalone & cluster): success
✅ - e2e-python-test (standalone & cluster): success
✅ - clean (standalone & cluster & standalone_auth): success

wuyfee · 2024-11-30T14:15:23Z

$\color{red}{FAILURE}$
DETAILS
✅ - docker: success
✅ - deploy (standalone & cluster & standalone_auth): success
❌ - e2e-java-test (standalone & cluster & standalone_auth): failure
✅ - e2e-go-test (standalone & cluster): success
✅ - e2e-cpp-test (standalone & cluster): success
✅ - e2e-csharp-test (standalone & cluster): success
✅ - e2e-nodejs-test (standalone & cluster): success
✅ - e2e-python-test (standalone & cluster): success
✅ - clean (standalone & cluster & standalone_auth): success

fuhouyu · 2024-12-02T14:43:33Z

Test is error, I will be fix it later

wuyfee · 2024-12-03T14:08:40Z

$\color{red}{FAILURE}$
DETAILS
✅ - docker: success
✅ - deploy (standalone & cluster & standalone_auth): success
❌ - e2e-java-test (standalone & cluster & standalone_auth): failure
✅ - e2e-go-test (standalone & cluster): success
✅ - e2e-cpp-test (standalone & cluster): success
✅ - e2e-csharp-test (standalone & cluster): success
✅ - e2e-nodejs-test (standalone & cluster): success
✅ - e2e-python-test (standalone & cluster): success
✅ - clean (standalone & cluster & standalone_auth): success

wuyfee · 2024-12-03T14:27:01Z

$\color{red}{FAILURE}$
DETAILS
✅ - docker: success
✅ - deploy (standalone & cluster & standalone_auth): success
❌ - e2e-java-test (standalone & cluster & standalone_auth): failure
✅ - e2e-go-test (standalone & cluster): success
✅ - e2e-cpp-test (standalone & cluster): success
✅ - e2e-csharp-test (standalone & cluster): success
✅ - e2e-nodejs-test (standalone & cluster): success
✅ - e2e-python-test (standalone & cluster): success
✅ - clean (standalone & cluster & standalone_auth): success

wuyfee · 2024-12-07T02:28:52Z

$\color{red}{FAILURE}$
DETAILS
✅ - docker: success
✅ - deploy (standalone & cluster & standalone_auth): success
❌ - e2e-java-test (standalone & cluster & standalone_auth): failure
✅ - e2e-go-test (standalone & cluster): success
✅ - e2e-cpp-test (standalone & cluster): success
✅ - e2e-csharp-test (standalone & cluster): success
✅ - e2e-nodejs-test (standalone & cluster): success
✅ - e2e-python-test (standalone & cluster): success
✅ - clean (standalone & cluster & standalone_auth): success

wuyfee · 2024-12-07T03:22:14Z

$\color{red}{FAILURE}$
DETAILS
✅ - docker: success
✅ - deploy (standalone & cluster & standalone_auth): success
❌ - e2e-java-test (standalone & cluster & standalone_auth): failure
✅ - e2e-go-test (standalone & cluster): success
✅ - e2e-cpp-test (standalone & cluster): success
✅ - e2e-csharp-test (standalone & cluster): success
✅ - e2e-nodejs-test (standalone & cluster): success
✅ - e2e-python-test (standalone & cluster): success
✅ - clean (standalone & cluster & standalone_auth): success

fuhouyu added 10 commits July 31, 2024 21:12

FIX [ISSUE alibaba#12446] macInstance 补充日志

1b5cb99

Merge branch 'hotfix-log' into develop

39b40a9

UPDATE [ISSUE alibaba#12466] serviceMetadata environment variables co…

1e1444a

…nfig

fixed DefaultParamChecker and DefaultParamCheckerTest codeStyle

51ef382

Merge branch 'alibaba:develop' into develop

6c19dfd

Merge branch 'alibaba:develop' into develop

3107692

Merge branch 'alibaba:develop' into develop

0e3a684

Merge branch 'alibaba:develop' into develop

d6d3fa4

Merge branch 'alibaba:develop' into develop

9ef77e7

Merge branch 'alibaba:develop' into develop

f943e72

fix: alibaba#12889 ,when namespace is not exists,then throw error

2678342

fuhouyu force-pushed the develop branch from 22a4c94 to 2678342 Compare November 30, 2024 10:05

fix: extensionsParamChecker

589afad

fix: default public namespace error

aa8e847

test: naming-test error

ac83b9d

fuhouyu force-pushed the develop branch from a9edc21 to ac83b9d Compare December 3, 2024 13:36

test: naming-test error

01a3890

Merge branch 'alibaba:develop' into develop

a5236cc

test: naming error fix

1975f3a

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

FIX When the namespace does not exist, it is still possible to create configuration items #12890

FIX When the namespace does not exist, it is still possible to create configuration items #12890

fuhouyu commented Nov 23, 2024 •

edited

Loading

github-actions bot commented Nov 23, 2024

codecov-commenter commented Nov 23, 2024 •

edited

Loading

wuyfee commented Nov 23, 2024

shiyiyue1102 commented Nov 26, 2024

fuhouyu commented Nov 26, 2024

shiyiyue1102 commented Nov 27, 2024

fuhouyu commented Nov 27, 2024

fuhouyu commented Nov 30, 2024

wuyfee commented Nov 30, 2024

wuyfee commented Nov 30, 2024

wuyfee commented Nov 30, 2024

wuyfee commented Nov 30, 2024

wuyfee commented Nov 30, 2024

fuhouyu commented Dec 2, 2024

wuyfee commented Dec 3, 2024

wuyfee commented Dec 3, 2024

wuyfee commented Dec 7, 2024

wuyfee commented Dec 7, 2024

FIX When the namespace does not exist, it is still possible to create configuration items #12890

Are you sure you want to change the base?

FIX When the namespace does not exist, it is still possible to create configuration items #12890

Conversation

fuhouyu commented Nov 23, 2024 • edited Loading

What is the purpose of the change

Brief changelog

Verifying this change

github-actions bot commented Nov 23, 2024

codecov-commenter commented Nov 23, 2024 • edited Loading

Codecov Report

wuyfee commented Nov 23, 2024

shiyiyue1102 commented Nov 26, 2024

fuhouyu commented Nov 26, 2024

shiyiyue1102 commented Nov 27, 2024

fuhouyu commented Nov 27, 2024

fuhouyu commented Nov 30, 2024

wuyfee commented Nov 30, 2024

wuyfee commented Nov 30, 2024

wuyfee commented Nov 30, 2024

wuyfee commented Nov 30, 2024

wuyfee commented Nov 30, 2024

fuhouyu commented Dec 2, 2024

wuyfee commented Dec 3, 2024

wuyfee commented Dec 3, 2024

wuyfee commented Dec 7, 2024

wuyfee commented Dec 7, 2024

fuhouyu commented Nov 23, 2024 •

edited

Loading

codecov-commenter commented Nov 23, 2024 •

edited

Loading