Allow setting port=0 to use OS-assigned port. #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using port=0 is useful for ephemeral servers (eg for tests) where a given port can't necessarily be guaranteed to be available. Setting port=0 was failing because the _trigger_server method then attempted to connect to the server with port 0, which didn't work. Fix this by updating the port from the server's socket before attempting to connect.
|
Note: I've not been able to get the full test suite to run locally - it appears to hang within |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Allow using
port=0when creating a Controller to use an OS-assigned port. Usingport=0is useful for ephemeral servers (eg for tests) where a given port can't necessarily be guaranteed to be available.Are there changes in behavior for the user?
No changes to existing behaviour (when specifying a non-zero port, or leaving it at the default).
Related issue number
Closes: #276 (this implements the changes described in the comments on that issue)
Checklist
py310-nocov(test_server.pyonly)NEWS.rstfile