Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature new response property in ClientWebSocketResponse #8572

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

leszekhanusz
Copy link

@leszekhanusz leszekhanusz commented Aug 1, 2024

What do these changes do?

It is adding a new response public attribute to the ClientWebSocketResponse class.

It allows users to have access to response headers and cookies of a websocket request without needing to use the private _response attribute.

Are there changes in behavior for the user?

No

Is it a substantial burden for the maintainers to support this?

No, this is quite straightforward.

Related issue number

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
  • Add a new news fragment into the CHANGES/ folder

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Aug 1, 2024
Copy link

codecov bot commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.75%. Comparing base (0070045) to head (932fa6d).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8572   +/-   ##
=======================================
  Coverage   98.75%   98.75%           
=======================================
  Files         122      122           
  Lines       36976    36980    +4     
  Branches     4412     4413    +1     
=======================================
+ Hits        36517    36521    +4     
  Misses        313      313           
  Partials      146      146           
Flag Coverage Δ
CI-GHA 98.64% <100.00%> (+<0.01%) ⬆️
OS-Linux 98.33% <100.00%> (+<0.01%) ⬆️
OS-Windows 96.18% <100.00%> (+<0.01%) ⬆️
OS-macOS 97.44% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 97.28% <100.00%> (+<0.01%) ⬆️
Py-3.10.15 97.82% <100.00%> (-0.06%) ⬇️
Py-3.11.10 ?
Py-3.11.11 97.86% <100.00%> (-0.07%) ⬇️
Py-3.11.9 97.34% <100.00%> (+<0.01%) ⬆️
Py-3.12.7 ?
Py-3.12.8 98.38% <100.00%> (+<0.01%) ⬆️
Py-3.13.0 ?
Py-3.13.1 98.37% <100.00%> (-0.01%) ⬇️
Py-3.9.13 97.20% <100.00%> (-0.01%) ⬇️
Py-3.9.20 97.78% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.16 97.35% <100.00%> (-0.01%) ⬇️
VM-macos 97.44% <100.00%> (+<0.01%) ⬆️
VM-ubuntu 98.33% <100.00%> (+<0.01%) ⬆️
VM-windows 96.18% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Dec 16, 2024

CodSpeed Performance Report

Merging #8572 will not alter performance

Comparing leszekhanusz:feature_ClientWebsocketResponse_response_property (932fa6d) with master (0070045)

Summary

✅ 47 untouched benchmarks

@bdraco bdraco added the backport-3.12 Trigger automatic backporting to the 3.12 release branch by Patchback robot label Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-3.12 Trigger automatic backporting to the 3.12 release branch by Patchback robot bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants