Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explicitly throw error for socks5 proxy since is not supported supported currently and will be implied disconnected if connect to #10147

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

NewUserHa
Copy link
Contributor

What do these changes do?

explicitly throw error for socks5 proxy since is not supported supported currently and will be implied disconnected if connect to

Are there changes in behavior for the user?

N/A

Is it a substantial burden for the maintainers to support this?

N/A

Related issue number

Fixes #10025

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES/ folder
    • name it <issue_or_pr_num>.<type>.rst (e.g. 588.bugfix.rst)

    • if you don't have an issue number, change it to the pull request
      number after creating the PR

      • .bugfix: A bug fix for something the maintainers deemed an
        improper undesired behavior that got corrected to match
        pre-agreed expectations.
      • .feature: A new behavior, public APIs. That sort of stuff.
      • .deprecation: A declaration of future API removals and breaking
        changes in behavior.
      • .breaking: When something public is removed in a breaking way.
        Could be deprecated in an earlier release.
      • .doc: Notable updates to the documentation structure or build
        process.
      • .packaging: Notes for downstreams about unobvious side effects
        and tooling. Changes in the test invocation considerations and
        runtime assumptions.
      • .contrib: Stuff that affects the contributor experience. e.g.
        Running tests, building the docs, setting up the development
        environment.
      • .misc: Changes that are hard to assign to any of the above
        categories.
    • Make sure to use full sentences with correct case and punctuation,
      for example:

      Fixed issue with non-ascii contents in doctest text files
      -- by :user:`contributor-gh-handle`.

      Use the past tense or the present tense a non-imperative mood,
      referring to what's changed compared to the last released version
      of this project.

@NewUserHa NewUserHa requested a review from asvetlov as a code owner December 8, 2024 20:16
Copy link

codspeed-hq bot commented Dec 8, 2024

CodSpeed Performance Report

Merging #10147 will not alter performance

Comparing NewUserHa:patch-8 (d0babf5) with master (6200513)

Summary

✅ 47 untouched benchmarks

@Dreamsorcerer Dreamsorcerer added the backport-3.12 Trigger automatic backporting to the 3.12 release branch by Patchback robot label Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-3.12 Trigger automatic backporting to the 3.12 release branch by Patchback robot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

shouldn env_proxy affect after proxy that provided by users from code
2 participants