-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the ability to consider reactions #1086
base: main
Are you sure you want to change the base?
Conversation
Hello @gorzelinski , we started to review the PR, but can you please meanwhile fix the failed checks of the PR? |
Hey @dsame, sure, I'll look into it ASAP. |
Should I do something more? As I see, the checks are passing now. |
cc: @gorzelinski thanks for contributing this! cc: @marko-zivic-93 @MaksimZhukov @dusan-trickovic friendly ping. Please review when you folks get a chance. This will help a lot more issues stay active that are being reacted to. Thank you for maintaining this action for us! |
Hey @nitrocode, do we need additional reviews? Sorry for bothering you, but avoiding merge conflicts would be great. |
Hi @gorzelinski , I do not manage this repo. I was just trying to get this reviewed so we can eventually get it merged. I can see from past merges that each merge seemed to require at least 2 approvals before merging https://github.com/actions/stale/pulls?q=is%3Apr+is%3Amerged+-author%3Aapp%2Fdependabot+ |
@nitrocode Oh, I didn't know. Thanks for the info anyway. |
|
||
If set to `false`, any reaction to an issue will be considered an update. | ||
|
||
Default value: unset |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I personally would have this set by default
Description:
As mentioned in #861 (comment), in some projects it’s useful to track reactions as activity. This PR adds such an option (disabled by default). We tested it on our primary and supporting repositories, and it works as expected.
Related issue:
#861
Check list: