Fixes #85. Add support for multiple server ids. #86
+200
−5,082
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does not fully address #85; it does not allow the user to specify a list of servers as follows:
As GitHub Actions do not appear to support YAML parameters.
However, it does allow the user to specify a list of server ids as follows:
Which produces a settings xml as follows:
In general, the action concatenates the value of
server-id
to the value ofserver-id-list
, removes any duplicates, and produces oneserver
entry per value.For example,
server-id
norserver-id-list
, the action concatenates the default value ofserver-id
(github
) to the default value ofserver-id-list
([github]
), producing ([github, github]
); the action then removes the duplicategithub
and produces oneserver
entry for the remaininggithub
.server-id
but notserver-id-list
, the action concatenates the value ofserver-id
(say,server
) and the default value ofserver-id-list
([github]
), producing ([github, server]
); the action then produces two server entries, one forgithub
and one forserver
.server-id-list
but notserver-id
, the action concatenates the default value ofserver-id
(github
) to the value ofserver-id-list
(say,[server1, server2]
), producing ([github, server1, server2]
); the action then produces three server entries, one forgithub
, one forserver1
, and one forserver2
.A successful run of this PR is here:
https://github.com/drewctaylor/constrain/actions/runs/191542087/workflow