Disable rustup self-updating
#10970
Open
Disable rustup self-updating
#10970
+29
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`rustup` has a mechanism for self-updating, which triggers whenever you request it to install a new toolchain. This is annoying to have happen in CI though, since it increases build time for no benefit. So let's disable this mechanism.
Re2906
approved these changes
Dec 16, 2024
Re2906
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
rustuphas a mechanism for self-updating, which triggers whenever you request it to install a new toolchain. This is annoying to have happen in CI though, since it increases build time for no benefit (both the check itself, and the eventual update if rustup deems it necessary).So let's disable this!
Since this is a behavioural change, it could be considered a breaking change, though I will argue that it isn't, people shouldn't need to update
rustupitself during a build (rustup updateto fetch a newerrustc/cargostill works fine).Related issue:
#246, the proposed workaround in there (
--no-self-update) wouldn't be necessary any more.Check list