Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[helm]feat: add fullname override option for gha-runner-scale-set #3854

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

c4po
Copy link

@c4po c4po commented Dec 17, 2024

Background

I want to introduce a feature in the gha-runner-scale-set Helm chart that allows users to override the gha-runner-scale-set.fullname from the values.yaml file. This feature is necessary to support the installation of two runner scale sets in the same namespace with the same scale set name but targeting different GitHub configuration URLs. This is particularly useful for us to migrate runner sets from GitHub Enterprise Server (GHES) to GitHub Enterprise Cloud (GHEC).

Changes

  • Introduced a fullnameOverride field in values.yaml to allow users to specify a custom full name for the runner scale set.
  • Updated _helpers.tpl to use the override value if provided, enabling deployment of multiple runner scale sets in the same namespace with different GitHub configuration URLs.
  • This change supports have multiple runner scale sets in the same namespace with the same scale set name.

@c4po c4po requested review from mumoshu, toast-gear, rentziass and a team as code owners December 17, 2024 16:50
@c4po c4po changed the title feat: add fullname override option for gha-runner-scale-set [helm]feat: add fullname override option for gha-runner-scale-set Dec 17, 2024
@c4po c4po force-pushed the override-fullname branch from 739ea2c to dd0e626 Compare December 18, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant