New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AutoscalingRunnerSet env: not Rendering correctly #3826

Open

thinkbiggerltd wants to merge 1 commit into actions:master from thinkbiggerltd:bugfix/helperContainerRunnerEnv

thinkbiggerltd commented Nov 28, 2024 •

edited

Loading

ChangeLog:

Added Trim to Container Runner env: rendering
AutoscalingRunnerSet env: not rendering properly, as follows

       env:
          -
            name: http_proxy
            value: http://my-http-proxy
          -
            name: https_proxy
            value: http://my-http-proxy
          - name: DOCKER_HOST
            value: unix:///var/run/docker.sock
          - name: RUNNER_WAIT_FOR_DOCKER_IN_SECONDS

Added Trim to helper.tpl to resolve. Now rendering to the following

        env:
          - name: http_proxy
            value: http://my-http-proxy
          - name: https_proxy
            value: http://my-http-proxy
          - name: DOCKER_HOST
            value: unix:///var/run/docker.sock
          - name: RUNNER_WAIT_FOR_DOCKER_IN_SECONDS


          Runner ENV Rendering Helper.tpl Change

d0d6bd1

ChangeLog:
- Added Trim to Container Runner env: rendering

thinkbiggerltd requested review from mumoshu, toast-gear, rentziass and a team as code owners

November 28, 2024 11:26

thinkbiggerltd changed the title ~~Runner ENV Rendering Helper.tpl Change~~ AutoscalingRunnerSet env: not Rendering correctly

Link- added the attention label

Link- modified the milestones: gha-runner-scale-set-0.10.1, gha-runner-scale-set-0.10.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mumoshu Awaiting requested review from mumoshu mumoshu is a code owner

toast-gear Awaiting requested review from toast-gear toast-gear is a code owner

rentziass Awaiting requested review from rentziass rentziass is a code owner

At least 1 approving review is required to merge this pull request.

Labels