Allow Actions Github Client HTTP timeout to be configurable #3782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jb-2020
requested review from
mumoshu,
toast-gear,
rentziass and
a team
as code owners
|
Can we get some eyes on this PR please? Reducing the timeout will greatly help us reduce the number of hung runner pods. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're on GHES and believe the 5 minute timeout on the listener to be too high for our network flow
This PR allows us to configure the HTTP timeout via the environment variable:
ACTIONS_HTTP_CLIENT_TIMEOUT_SECONDSIf this variable is not provided then we will default to the current 5 minute (300 second) timeout.