Update prettier, change print width to 120, and enable dangling commas for functions #371
Conversation
|
At this point, I'd rather not take a huge PR like this into the repo right before the release even if it should not have any real impact on performance in theory. |
|
Adding v3.1 label to match the label on #370 |
fully agreed, this was definitely meant for after the release. Thanks for adding the label. |
julienw
force-pushed
the
change-print-width
branch
2 times, most recently
from
ec73337 to
231c0d7
Compare
yeah, I was waiting to see if there was some interest before doing more work :-) |
|
I'd definitely prefer some width-limit, especially for the html files. |
julienw
force-pushed
the
change-print-width
branch
from
231c0d7 to
c6b86de
Compare
|
I rebased and refreshed all affected benchmarks. On my Linux: Firefox Before: Firefox After: Chrome Before: Chrome After: (I don't have a Mac so I can't try Safari) |
| @@ -1,4 +1,4 @@ | |||
| <!DOCTYPE html> | |||
| <!doctype html> | |||
There was a problem hiding this comment.
What's up with these DOCTYPE change? These don't seem desirable.
There was a problem hiding this comment.
This comes from the prettier update to v3 (see https://prettier.io/blog/2023/07/05/3.0.0.html#html). There's also no option to disable this behavior.
The doctype is case insensitive so IMO it's not important. I'm glad somebody else has an opinion about it so that I don't need to have one.
| @@ -1,12 +1,4 @@ | |||
| { | |||
| "arrowParens": "always", | |||
There was a problem hiding this comment.
Why are we making all these other changes to prettier?
There was a problem hiding this comment.
You can find out more if you look at the individual commits, as there's one commit for each logical change.
In short a lot of them are the defaults (see 3rd commit), except printWidth and trailingComma which are the changes by this PR.
Changing trailingComma is beneficial because it makes better diffs: with the old style, there's no trailing comma, and therefore when function parameters or array properties or object properties are added or removed, the previous line also shows up in a diff. If it has a trailing comma, then it isn't changed.
There was a problem hiding this comment.
Not removing the default ones would make this PR easier to review/less scary
|
ping @rniwa |
| @@ -1,12 +1,4 @@ | |||
| { | |||
| "arrowParens": "always", | |||
There was a problem hiding this comment.
Not removing the default ones would make this PR easier to review/less scary
Fixes #370
I didn't regenerate all workloads (yet). Please do not land this just yet, this PR is here so that we can decide about #370.
I made separate commits so that we can easily see the effect of each action: