Remove the Wasm 1.0 banner #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Generally LGTM, but maybe we should separate the dependence updates from the functional change :) |
|
@bvisness would you be open to revert changes in gemfile? |
tomayac
approved these changes
Nov 7, 2024
chicoxyzzy
approved these changes
Nov 7, 2024
|
I'll revert the gemfile stuff, yeah. |
|
@bvisness Friendly ping; could you revert the gemfile changes here? |
bvisness
force-pushed
the
update-banner
branch
from
addfcf8 to
ac46080
Compare
|
Done. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per some CG meeting discussion :)
(This PR is a bit cheeky, and it may be better to instead update the contents of the banner to reflect what is currently shipped.)