Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise Web implementation limits for imports and exports #1766

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

tlively
Copy link
Member

@tlively tlively commented Jul 16, 2024

At the CG meeting today (July 16, 2024), we had unanimous consensus to raise the limits on the number of imports and exports on the Web to 1,000,000. See WebAssembly/design#1520 for context.

At the CG meeting today (July 16, 2024), we had unanimous consensus to raise the limits on the number of imports and exports on the Web to 1,000,000. See WebAssembly/design#1520 for context.
@tlively
Copy link
Member Author

tlively commented Jul 16, 2024

Implementation status for this change:

@eqrion
Copy link
Contributor

eqrion commented Jul 16, 2024

SpiderMonkey bug which should make it into Fx130.

fitzgen added a commit to fitzgen/wasm-tools that referenced this pull request Jul 16, 2024
github-merge-queue bot pushed a commit to bytecodealliance/wasm-tools that referenced this pull request Jul 16, 2024
Copy link
Member

@rossberg rossberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but should we hold off landing this on main until the candidate recommendation release process for 2.0 is through? We probably ought to not add any feature changes while it is under public "review".

Copy link
Contributor

@conrad-watt conrad-watt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

WRT questions about the W3C cut - is there not still a distinction between the WG living standard, which is (currently) subject to the review period and needs to be explicitly snapshotted, and the CG living "draft" standard? I would have thought we could still freely update the CG draft standard without interfering with the WG's review period.

see WG guidelines here
https://sideshowbarker.github.io/w3c-faq/#how-can-i-make-a-living-standard-from-my-spec

and CG guidelines here
https://sideshowbarker.github.io/w3c-faq/#cg-living-standards

@rossberg
Copy link
Member

I am not sure. Technically, we haven't reached the W3's living standard status yet, only after we're through with the current process (hopefully very soon). And CI currently pushes every commit to W3C TR immediately. There are no two versions or places in the current setup. My understanding is that the current URL we push to is going to become the place for the living standard CR as well, in which case this setup makes sense and is not worth changing anymore. But IIUC it also means that we have to be careful not to merge functional changes right now. But I may be wrong.

@conrad-watt
Copy link
Contributor

Is the public "review" mentioned above the same thing as the "exclusion opportunity" triggered by new CRs? Interpreting the above FAQ, new pushes to W3C TR don't trigger new exclusion opportunities unless we explicitly tag the push as a snapshot. Am I understanding correctly that we're currently in the 60 exclusion opportunity period for the "2.0 snapshot"?

@Ms2ger Ms2ger requested a review from sideshowbarker October 7, 2024 10:20
hubot pushed a commit to v8/v8 that referenced this pull request Dec 10, 2024
In accordance with the recent spec change, see:
WebAssembly/design#1520
WebAssembly/spec#1766

Change-Id: I111776bc7b3282c6bd98f6d11f35e119fc83ef81
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6085575
Reviewed-by: Matthias Liedtke <[email protected]>
Commit-Queue: Jakob Kummerow <[email protected]>
Cr-Commit-Position: refs/heads/main@{#97668}
@jakobkummerow
Copy link
Contributor

The recent activity on the linked issue reminded me that we still had to bump the limit in V8, so we've just done that. It'll be in Chrome 133.

@dschuff
Copy link
Member

dschuff commented Dec 10, 2024

My current understanding is that after we go to CR, then we can push whatever we want as a CR Draft (see https://www.w3.org/policies/process/#maturity-stages) which does not have any process requirements and does not trigger an exclusion opportunity; I think that can continue to be automated and publish whatever the WG decides to merge into the spec at stage 5. Then we will periodically publish CR Snapshots, which does have a process (an "Update Request" instead of a "Transition Request") and does trigger a patent exclusion.

@jakobkummerow
Copy link
Contributor

Note on this PR: the "limits" spec test also needs to be updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants