Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved factory manufacture #4153

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Monsterovich
Copy link
Contributor

When a droid template is modified and queued, we save the pointer to the new template in the old one, so that we can switch to it later.

2024-12-14.05-01-45.mp4

@Monsterovich Monsterovich force-pushed the fix-production-in-factories2 branch from 0c34ad5 to c2e40cd Compare December 14, 2024 12:53
@Monsterovich Monsterovich force-pushed the fix-production-in-factories2 branch from 4c9de79 to 20f3cbc Compare December 14, 2024 13:18
@maxsupermanhd
Copy link
Member

This looks way more correct to me, I assume infinite repeat with 1 ordered would result in same behaviour, right? (and with +1 being rendered)

What about client-side setting to optionally cancel or retain queue? I would personally probably not use it but bet there are some people who would be into that kind of stuff.

@Monsterovich
Copy link
Contributor Author

@maxsupermanhd

This looks way more correct to me, I assume infinite repeat with 1 ordered would result in same behaviour, right? (and with +1 being rendered)

Yeah, it'll finish that remaining droid and then it'll start making a new template (with count 4 on my screenshot).

pic

What about client-side setting to optionally cancel or retain queue?

Later. May be even in the next PR.

@vaut
Copy link
Contributor

vaut commented Dec 14, 2024

tested

@maxsupermanhd
Copy link
Member

maxsupermanhd commented Dec 19, 2024

Found edge case:

When you have infinite order (or any complex order) and you have unit currently ordered and producing but you want to force-drop production progress, previously I just cancelled the queue with right click and it would switch to next in queue, currently no matter if I cancel the order it still finishes producing the unit and the only way to cancel it is to drop all orders with double right click on factory.

This is very annoying and has to be addressed in some way.

Example: I want to stop producing incendiary mortar immediately and forgot to dequeue it and end up completely wiping factory queues instead of specifically cancelling currently producing unit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants