Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a shorthand for the formatted wzstring #4022

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Monsterovich
Copy link
Contributor

@Monsterovich Monsterovich commented Jul 21, 2024

The equivalent of std::format from C++20.

@KJeff01 KJeff01 added the PR: Needs Review Check if this PR is still relevant or needs minor tweaks to be ready to merge label Oct 2, 2024
@KJeff01 KJeff01 added this to the 4.6.0 milestone Oct 2, 2024
lib/framework/wzstring.h Outdated Show resolved Hide resolved
Copy link
Member

@ManManson ManManson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small nitpick, otherwise LGTM.

@ManManson ManManson added Enhancement and removed PR: Needs Review Check if this PR is still relevant or needs minor tweaks to be ready to merge labels Nov 17, 2024
@Monsterovich
Copy link
Contributor Author

@KJeff01 @past-due merge?

@KJeff01
Copy link
Member

KJeff01 commented Dec 15, 2024

It says there are merge conflicts yet won't say which file for some reason. So needs a rebase. Pastdue said he may need to add tweaks for potential compiler warnings last time I poked him about this.

I am also trying to reduce the chances of merging large PRs that touch many files until pastdue finishes his big project (probably art-rev switcher) to avoid more merge-conflict troubles for him.

I keep github notifications turned off. You can DM me Discord for faster contact however.

@Monsterovich
Copy link
Contributor Author

Monsterovich commented Dec 15, 2024

It says there are merge conflicts yet won't say which file for some reason.

@KJeff01 Hm. I've successfully merged this branch with master, there were no conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants