Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "isFlying" JS field to Droid objects #3830

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add "isFlying" JS field to Droid objects #3830

wants to merge 1 commit into from

Conversation

DARwins1
Copy link
Member

@DARwins1 DARwins1 commented Jun 1, 2024

Partner PR to #3508
Adds an isFlying field to JS Droid objects, which is true if the droid (VTOL or Transport) is currently in the air, false otherwise.

@DARwins1 DARwins1 mentioned this pull request Jun 1, 2024
Merged
@KJeff01 KJeff01 added the PR: Needs Review Check if this PR is still relevant or needs minor tweaks to be ready to merge label Oct 2, 2024
@KJeff01 KJeff01 added this to the 4.6.0 milestone Oct 2, 2024
@KJeff01
Copy link
Member

KJeff01 commented Oct 2, 2024

You'll need to rebase or force push a manual fix. A few isFlying()s will need explicit transporter checks.

action.cpp - We don't want to suddenly move transporters away from structures that a truck built under it.
combat.cpp - Transporters are always floating above the ground, so don't predict towards the tile height.

@KJeff01 KJeff01 removed the PR: Needs Review Check if this PR is still relevant or needs minor tweaks to be ready to merge label Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@DARwins1 @KJeff01