exploration for Apollo Client integration #2698
Draft
+2,195
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phryneas
commented
Nov 4, 2024
Comment on lines
+125
to
+135
| streamedValues: new Proxy( | ||
| {}, | ||
| { | ||
| set(t, key, v) { | ||
| const res = Reflect.set(t, key, v) | ||
| window.__TSR__ROUTER__ && | ||
| __TSR__ROUTER__.emit({ type: 'onStreamedValue', key }) | ||
| return res | ||
| }, | ||
| }, | ||
| ), |
There was a problem hiding this comment.
Streamed values arriving now emits a router event.
phryneas
commented
Nov 4, 2024
|
|
||
| const handledEvents = new WeakSet<object>() | ||
|
|
||
| export const ApolloProvider = WrapApolloProvider((props) => { |
There was a problem hiding this comment.
This file is essentially all that's needed for Apollo Client streaming SSR integration with fetch-as-you-render (useSuspenseQuery etc).
There was a problem hiding this comment.
This would end up in it's own package, I guess?
phryneas
commented
Nov 7, 2024
| // @ts-ignore unavoidable due to the ternary in arguments | ||
| router.options.context.preloadQuery = | ||
| createTransportedQueryPreloader(apolloClient) | ||
| router.options.transformer = defaultTransformer.withTransformers([ |
There was a problem hiding this comment.
I'm gonna be honest, I would prefer to have a router.options.transformers option - that way we could merge user-supplied transformers with "library-supplied" ones, which is currently not possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made a 15 minute video explaining some of the thoughts behind this, so that might be a starting point :)
https://www.youtube.com/watch?v=G-8Q_o2eKhg
This just copies over another example page so you can kinda ignore the first commit when looking at the diff.