Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove data migration #6683

Merged
merged 1 commit into from
Dec 20, 2024
Merged

chore: remove data migration #6683

merged 1 commit into from
Dec 20, 2024

Conversation

srikanthccv
Copy link
Member

@srikanthccv srikanthccv commented Dec 20, 2024

Summary

This is no longer needed after the last release.


Important

Remove unnecessary ingestion dashboard data migration logic from the codebase.

  • Removal:
    • Deleted ingestion_dashboard.go file, removing the entire data migration logic for the ingestion dashboard.
    • Removed migrateIngestionDashboard function call and related logic from Migrate() in migate.go.
  • Misc:
    • Removed unused import zap from migate.go.

This description was created by Ellipsis for 4595c29. It will automatically update as commits are pushed.

Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions github-actions bot added the chore label Dec 20, 2024
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 4595c29 in 28 seconds

More details
  • Looked at 2774 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. pkg/query-service/migrate/migate.go:53
  • Draft comment:
    The migrateIngestionDashboard function is referenced in this file but has been removed. This will cause a compilation error. Please remove or replace the reference to this function.
  • Reason this comment was not posted:
    Comment looked like it was already resolved.

Workflow ID: wflow_jSado8EsBPaiPnn0


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@nityanandagohain nityanandagohain merged commit b36ef94 into main Dec 20, 2024
19 of 22 checks passed
@nityanandagohain nityanandagohain deleted the remove-migration branch December 20, 2024 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants