Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add log events for timezone interactions in date/time picker and timezone adaptation #6676

Merged
merged 3 commits into from
Dec 20, 2024

Conversation

ahmadshaheer
Copy link
Collaborator

@ahmadshaheer ahmadshaheer commented Dec 19, 2024

Summary

  • Clicking on the Current Timezone inside date/time picker popover
  • Clicking on the timezone badge in date/time picker input
  • Clicking on a timezone inside the timezone picker
  • Clicking on Clear override in timezone adaptation settings

Related Issues / PR's

#6644

Screenshots

NA

Affected Areas and Manually Tested Areas


Important

Add logging for timezone interactions in date/time picker and adaptation settings.

  • Logging:
    • Add logEvent for opening timezone picker from time range input badge in CustomTimePicker.tsx.
    • Add logEvent for opening timezone picker from time range picker footer in CustomTimePickerPopoverContent.tsx.
    • Add logEvent for selecting a new timezone in TimezonePicker.tsx.
    • Add logEvent for clearing timezone override and toggling adaptation in TimezoneAdaptation.tsx.

This description was created by Ellipsis for 33e12ad. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 33e12ad in 1 minute and 26 seconds

More details
  • Looked at 140 lines of code in 4 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. frontend/src/components/CustomTimePicker/CustomTimePicker.tsx:305
  • Draft comment:
    Consider defining log messages as constants or using a logging utility to avoid hardcoded strings and potential inconsistencies. This applies to other logEvent calls as well.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The logEvent function is used consistently across the files to log specific user interactions. However, the log messages are hardcoded strings, which could lead to inconsistencies or typos. It would be better to define these log messages as constants or use a logging utility to manage them.
2. frontend/src/container/MySettings/TimezoneAdaptation/TimezoneAdaptation.tsx:52
  • Draft comment:
    Avoid using inline styles in React components. Consider using CSS classes or styled components instead.
  • Reason this comment was not posted:
    Comment was on unchanged code.

Workflow ID: wflow_cdqfpjQhRRKAjgPo


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@YounixM YounixM force-pushed the chore/add-log-events-to-timezone-picker branch from 33e12ad to 56d1cec Compare December 20, 2024 06:00
@ahmadshaheer ahmadshaheer merged commit 53ebd39 into main Dec 20, 2024
15 of 16 checks passed
@ahmadshaheer ahmadshaheer deleted the chore/add-log-events-to-timezone-picker branch December 20, 2024 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants