chore: revamp the frontend architecture #6598

vikrantgupta25 · 2024-12-05T07:11:49Z

Refactor

This PR takes care of moving away from redux as much as possible and streamlining the routing , sync setup calls and making sure we have deterministic actions based on API results. All the test cases have been fixed in sync with the latest design architecture

Contributes to - #5621 , https://github.com/SigNoz/engineering-pod/issues/2068

vikrantgupta25 · 2024-12-05T07:12:04Z

contributes to - https://github.com/SigNoz/engineering-pod/issues/2068

github-actions · 2024-12-05T07:12:05Z

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

github-actions · 2024-12-05T08:37:22Z

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

github-actions · 2024-12-05T08:37:27Z

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

github-actions · 2024-12-05T18:46:31Z

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

github-actions · 2024-12-05T18:47:40Z

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

github-actions · 2024-12-05T18:47:59Z

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

…tion

github-actions · 2024-12-11T03:20:26Z

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

ellipsis-dev

👍 Looks good to me! Reviewed everything up to 6eeab69 in 3 minutes and 58 seconds

More details

Looked at 8732 lines of code in 136 files
Skipped 0 files when reviewing.
Skipped posting 5 drafted comments based on config settings.

1. pkg/query-service/dao/sqlite/rbac.go:95

Draft comment:
Ensure that the model.Organization struct includes IsAnonymous and HasOptedUpdates fields, and that these fields are correctly populated before calling CreateOrg.
Reason this comment was not posted:
Confidence changes required: 50%
The CreateOrg function has been updated to include is_anonymous and has_opted_updates fields in the INSERT statement. This change should be reflected in the corresponding model and any related logic to ensure consistency.

2. frontend/src/providers/App/App.tsx:243

Draft comment:
Consider adding a check to ensure the AFTER_LOGIN event does not redundantly update the user state if the event is dispatched multiple times.
Reason this comment was not posted:
Confidence changes required: 50%
In the AppProvider component, the useEffect hook for setting the user state on login might not handle cases where the AFTER_LOGIN event is dispatched multiple times. Consider adding a check to prevent redundant state updates.

3. frontend/src/providers/App/App.tsx:259

Draft comment:
Ensure that any additional cleanup logic is handled in the LOGOUT event listener, if necessary.
Reason this comment was not posted:
Confidence changes required: 33%
In the AppProvider, the useEffect for LOGOUT event resets the state. Ensure that any additional cleanup logic is also handled here if needed.

4. frontend/src/providers/App/App.tsx:66

Draft comment:
Consider adding error handling for the user data fetch to manage potential issues during the fetch process.
Reason this comment was not posted:
Confidence changes required: 50%
In the AppProvider, the useEffect for fetching user data does not handle errors. Consider adding error handling to manage potential issues during the fetch.

5. pkg/query-service/dao/sqlite/rbac.go:92

Draft comment:
Do not add non-ClickHouse related functions to the ClickHouseReader interface. Use the DAO in the telemetry instance to access such information instead.
Reason this comment was not posted:
Comment was on unchanged code.

Workflow ID: wflow_hhchr3f8ChOUxn1y

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

srikanthccv · 2024-12-13T07:49:14Z

https://app.intercom.com/a/inbox/wmkurvb7/inbox/admin/6745296/conversation/5813#part_id=comment-5813-17320 more and more users are facing this and perhaps it became more visible and frequent

github-actions · 2024-12-16T07:38:55Z

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

ellipsis-dev

👍 Looks good to me! Incremental review on 4023a6c in 4 minutes and 56 seconds

More details

Looked at 6238 lines of code in 300 files
Skipped 0 files when reviewing.
Skipped posting 1 drafted comments based on config settings.

1. frontend/src/container/OnboardingContainer/Modules/AzureMonitoring/AppService/appService-installCentralCollector.md:40

Draft comment:
Use design tokens or predefined color constants instead of hardcoding color values for the signoz-ingestion-key header. This applies to other similar occurrences in the markdown files.
Reason this comment was not posted:
Comment was on unchanged code.

Workflow ID: wflow_sYOlnInX7BdBsOJw

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

srikanthccv · 2024-12-17T05:35:35Z

https://github.com/SigNoz/engineering-pod/issues/2096

github-actions · 2024-12-17T07:20:15Z

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

ellipsis-dev

👍 Looks good to me! Incremental review on 8763fe6 in 1 minute and 46 seconds

More details

Looked at 69 lines of code in 3 files
Skipped 0 files when reviewing.
Skipped posting 5 drafted comments based on config settings.

1. frontend/src/container/ResourceAttributesFilter/ResourceAttributesFilter.tsx:89

Draft comment:
The data-testid attribute should be consistently named. Please ensure it is correctly capitalized throughout the codebase.
Reason this comment was not posted:
Comment did not seem useful.

2. frontend/src/AppRoutes/Private.tsx:189

Draft comment:
Ensure that location is necessary in the dependency array. If not, it could lead to unnecessary re-renders.
Reason this comment was not posted:
Confidence changes required: 50%
The location dependency was added to the useEffect dependency array, which is a good practice to ensure the effect runs when the location changes. However, ensure that location is indeed necessary for the effect logic.

3. frontend/src/container/ResourceAttributesFilter/ResourceAttributesFilter.tsx:90

Draft comment:
Avoid using inline styles. Consider using CSS classes or styled components instead. This applies to other inline styles in this file as well.
Reason this comment was not posted:
Comment was on unchanged code.

4. frontend/src/container/ResourceAttributesFilter/ResourceAttributesFilter.tsx:122

Draft comment:
Avoid using inline styles. Consider using CSS classes or styled components instead. This applies to other inline styles in this file as well.
Reason this comment was not posted:
Marked as duplicate.

5. frontend/src/container/ResourceAttributesFilter/ResourceAttributesFilter.tsx:128

Draft comment:
Avoid using inline styles. Consider using CSS classes or styled components instead. This applies to other inline styles in this file as well.
Reason this comment was not posted:
Marked as duplicate.

Workflow ID: wflow_79OVsbiT6CaMoWb5

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

github-actions · 2024-12-17T08:08:45Z

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

vikrantgupta25 · 2024-12-17T08:08:48Z

contributes to - #5621

ellipsis-dev

👍 Looks good to me! Incremental review on a95d218 in 13 minutes and 33 seconds

More details

Looked at 109 lines of code in 4 files
Skipped 0 files when reviewing.
Skipped posting 4 drafted comments based on config settings.

1. frontend/src/container/LogsExplorerViews/index.tsx:292

Draft comment:
Remove the unnecessary console.log statement to clean up the code.
Reason this comment was not posted:
Comment looked like it was already resolved.

2. frontend/src/container/Login/index.tsx:86

Draft comment:
Avoid using inline styles. Replace inline styles with CSS classes or styled components where applicable.
Reason this comment was not posted:
Comment was not on a valid diff hunk.

3. frontend/src/container/Login/index.tsx:1

Draft comment:
Avoid using index.tsx for component files. Use a more descriptive file name for better debugging and searching.
Reason this comment was not posted:
Comment was on unchanged code.

4. frontend/src/container/LogsExplorerViews/index.tsx:292

Draft comment:
Avoid using index.tsx for component files. Use a more descriptive file name for better debugging and searching.
Reason this comment was not posted:
Marked as duplicate.

Workflow ID: wflow_tYinoYp2xQoGc5Vq

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

YounixM · 2024-12-18T19:20:06Z

frontend/src/AppRoutes/index.tsx

+			if (isCloudUserVal || isEECloudUser()) {
+				// if the user is on basic plan then remove billing
+				if (isOnBasicPlan) {
+					updatedRoutes = updatedRoutes.filter(


@vikrantgupta25: Billing should be should only to admins, do we have a check somewhere else ?

yes we have the same in SideNav.tsx

YounixM · 2024-12-18T19:25:48Z

frontend/src/container/AppLayout/index.tsx

+			licenses.onTrial &&
+			!licenses.trialConvertedToSubscription &&
+			!licenses.workSpaceBlock &&
+			getRemainingDays(licenses.trialEnd) < 7


NIT: destruct licenses and move 7 to const

YounixM · 2024-12-18T19:27:34Z

frontend/src/container/AppLayout/index.tsx

 		}
 	}, [isLoggedIn]);

 	const handleUpgrade = (): void => {
-		if (role === 'ADMIN') {
+		if (user.role === 'ADMIN') {


safety check

not required as the user.role will always be present [ default is VIEWER ]

YounixM · 2024-12-18T19:32:45Z

frontend/src/container/IngestionSettings/IngestionSettings.tsx


 	const { data: ingestionData, isFetching } = useQuery({
 		queryFn: getIngestionData,
-		queryKey: ['getIngestionData', user?.userId],
+		queryKey: ['getIngestionData', user?.id],


can add enabled check here.

will check in follow up PR , didn't update the existing code logics

YounixM · 2024-12-18T19:33:37Z

frontend/src/container/ListAlertRules/ListAlert.tsx

-		(state) => state.app,
-	);
+	const { user } = useAppContext();
+	// TODO[vikrantgupta25]: check with sagar on cleanup


cc : @SagarRajput-7 @vikrantgupta25

not required anymore, i cleaned it up ✅

will remove the TODO in follow up

YounixM · 2024-12-18T19:34:19Z

frontend/src/container/ListOfDashboard/ImportJSON/index.tsx

@@ -239,12 +225,6 @@ function ImportJSON({
 						>
 							{t('import_and_next')} &nbsp; <MoveRight size={14} />
 						</Button>
-
-						{isFeatureAlert && (


Was this not being consumed ?

no we removed usage based features so removed the check for everywhere

YounixM

Minor Comments, can be taken up in a separate PR.

feat: setup the app context to fetch users,licenses and feature flags

d383bee

github-actions bot added the docs required label Dec 5, 2024

github-actions bot added the enhancement New feature or request label Dec 5, 2024

feat: added global event listeners for after_login event

b1bc70d

vikrantgupta25 changed the title ~~feat: setup the app context to fetch users,licenses and feature flags~~ feat: architectural changes for app routes and private routes [ deprecating redux ] Dec 5, 2024

vikrantgupta25 changed the title ~~feat: architectural changes for app routes and private routes [ deprecating redux ]~~ feat: architectural changes for app routes and private routes [deprecating redux] Dec 5, 2024

vikrantgupta25 added 5 commits December 5, 2024 16:11

feat: remove redux from app state and private route

2f37f0e

feat: syncronize the approutes file

9f14088

feat: cleanup the private routes

43ec8e1

feat: handle login and logout

e1b6dbb

feat: cleanup the app layout file

83f4b19

vikrantgupta25 changed the title ~~feat: architectural changes for app routes and private routes [deprecating redux]~~ feat: revamp the frontend architecture Dec 5, 2024

vikrantgupta25 added docs not required and removed docs required labels Dec 5, 2024

vikrantgupta25 changed the title ~~feat: revamp the frontend architecture~~ chore: revamp the frontend architecture Dec 5, 2024

Merge remote-tracking branch 'origin' into cleanup-app-routes

a8b1308

github-actions bot added the chore label Dec 5, 2024

vikrantgupta25 removed the enhancement New feature or request label Dec 5, 2024

vikrantgupta25 added 5 commits December 6, 2024 01:06

feat: cleanup and syncronize side nav item

56ef96b

fix: minor small re-render issue

32906ba

feat: parallel processing for sync calls for faster bootup of applica…

6ce5cf3

…tion

feat: some refactoring for private routes

c29cd45

fix: entire application too much re-rendering

63f188e

vikrantgupta25 added 2 commits December 10, 2024 20:14

chore: update test-utils

566a594

Merge branch 'develop' into cleanup-app-routes

6eeab69

vikrantgupta25 marked this pull request as ready for review December 11, 2024 03:19

vikrantgupta25 requested review from srikanthccv and YounixM as code owners December 11, 2024 03:19

ellipsis-dev bot reviewed Dec 11, 2024

View reviewed changes

vikrantgupta25 added 2 commits December 16, 2024 13:05

chore: merge remote-tracking branch 'origin' into cleanup-app-routes

4023a6c

Merge branch 'develop' into cleanup-app-routes

08c4bd0

ellipsis-dev bot reviewed Dec 16, 2024

View reviewed changes

fix: jerky behaviour on entering the home page

8763fe6

ellipsis-dev bot reviewed Dec 17, 2024

View reviewed changes

vikrantgupta25 added 2 commits December 17, 2024 13:37

feat: handle the retention for login context flow

a95d218

Merge branch 'develop' into cleanup-app-routes

1c16916

ellipsis-dev bot reviewed Dec 17, 2024

View reviewed changes

vikrantgupta25 mentioned this pull request Dec 17, 2024

Login loses the past URL context #5621

Open

YounixM reviewed Dec 18, 2024

View reviewed changes

YounixM approved these changes Dec 18, 2024

View reviewed changes

Merge branch 'develop' into cleanup-app-routes

22863c0

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: revamp the frontend architecture #6598

chore: revamp the frontend architecture #6598

vikrantgupta25 commented Dec 5, 2024 •

edited

Loading

vikrantgupta25 commented Dec 5, 2024

github-actions bot commented Dec 5, 2024

github-actions bot commented Dec 5, 2024

github-actions bot commented Dec 5, 2024

github-actions bot commented Dec 5, 2024

github-actions bot commented Dec 5, 2024

github-actions bot commented Dec 5, 2024

github-actions bot commented Dec 11, 2024

ellipsis-dev bot left a comment

srikanthccv commented Dec 13, 2024

github-actions bot commented Dec 16, 2024

ellipsis-dev bot left a comment

srikanthccv commented Dec 17, 2024

github-actions bot commented Dec 17, 2024

ellipsis-dev bot left a comment

github-actions bot commented Dec 17, 2024

vikrantgupta25 commented Dec 17, 2024

ellipsis-dev bot left a comment

YounixM Dec 18, 2024

vikrantgupta25 Dec 18, 2024

YounixM Dec 18, 2024

YounixM Dec 18, 2024

vikrantgupta25 Dec 18, 2024

YounixM Dec 18, 2024 •

edited

Loading

vikrantgupta25 Dec 18, 2024

YounixM Dec 18, 2024

vikrantgupta25 Dec 18, 2024

vikrantgupta25 Dec 18, 2024

YounixM Dec 18, 2024

vikrantgupta25 Dec 18, 2024

YounixM left a comment

chore: revamp the frontend architecture #6598

Are you sure you want to change the base?

chore: revamp the frontend architecture #6598

Conversation

vikrantgupta25 commented Dec 5, 2024 • edited Loading

Refactor

vikrantgupta25 commented Dec 5, 2024

github-actions bot commented Dec 5, 2024

github-actions bot commented Dec 5, 2024

github-actions bot commented Dec 5, 2024

github-actions bot commented Dec 5, 2024

github-actions bot commented Dec 5, 2024

github-actions bot commented Dec 5, 2024

github-actions bot commented Dec 11, 2024

ellipsis-dev bot left a comment

Choose a reason for hiding this comment

srikanthccv commented Dec 13, 2024

github-actions bot commented Dec 16, 2024

ellipsis-dev bot left a comment

Choose a reason for hiding this comment

srikanthccv commented Dec 17, 2024

github-actions bot commented Dec 17, 2024

ellipsis-dev bot left a comment

Choose a reason for hiding this comment

github-actions bot commented Dec 17, 2024

vikrantgupta25 commented Dec 17, 2024

ellipsis-dev bot left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

YounixM Dec 18, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

YounixM left a comment

Choose a reason for hiding this comment

vikrantgupta25 commented Dec 5, 2024 •

edited

Loading

YounixM Dec 18, 2024 •

edited

Loading