-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release/v0.58.2 #6471
Release/v0.58.2 #6471
Conversation
* feat: support for window based pagination in new trace v4 * fix: update pagination logic * fix: update comment * fix: substract correct length * fix: revert changes * fix: add tests for querier * fix: rename matcher * fix: handle offset inmemory for list queries in traces * fix: correct var name * fix: add max pagination limit for traces
* feat: support for new enrichment logic in traces * fix: default test added * fix: update func name in links * Update pkg/query-service/utils/logs_test.go Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com> --------- Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-ALPINE318-BUSYBOX-6913411 - https://snyk.io/vuln/SNYK-ALPINE318-BUSYBOX-7249236 - https://snyk.io/vuln/SNYK-ALPINE318-BUSYBOX-7249265 - https://snyk.io/vuln/SNYK-ALPINE318-BUSYBOX-7249265 - https://snyk.io/vuln/SNYK-ALPINE318-BUSYBOX-7249419 Co-authored-by: snyk-bot <[email protected]>
…channels on opening the channels dropdown (#6416) * feat: add channel creation option and auto-refresh channels list on dropdown open * chore: move inline styles to style.ts * fix: show the prompt to ask admin if the user doesn't have permissions * fix: display create channel option only if the user has permission * fix: prevent repeated new alert event logs + log new channel option inside dropdown
* feat: use the license v2 key to fill licenses v3 on startup * chore: make the init only if the licenses v2 is present * chore: address review comments
Signed-off-by: Prashant Shahi <[email protected]>
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
1 similar comment
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Changes requested. Reviewed everything up to 9ccc686 in 1 minute and 50 seconds
More details
- Looked at
3159
lines of code in31
files - Skipped
0
files when reviewing. - Skipped posting
8
drafted comments based on config settings.
1. frontend/src/container/FormAlertRules/BasicInfo.tsx:218
- Draft comment:
Avoid using inline styles in React components. Instead, use external stylesheets, CSS classes, or styled components. This comment applies to other instances of inline styles in this file as well. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable:
The comment seems to be misplaced as there is no evidence of inline styles in the code. The code uses styled components and external stylesheets, which aligns with best practices. Therefore, the comment does not seem to be about a change made in this diff.
I might be missing some context or other parts of the codebase where inline styles are used, but based on the provided code, there is no indication of inline styles.
Given the provided code, there is no evidence of inline styles, so the comment seems irrelevant to the changes made.
The comment should be deleted as it does not pertain to any changes made in the diff and there is no evidence of inline styles in the provided code.
2. frontend/src/container/FormAlertRules/ChannelSelect/index.tsx:48
- Draft comment:
Avoid using inline styles in React components. Instead, use external stylesheets, CSS classes, or styled components. This comment applies to other instances of inline styles in this file as well. - Reason this comment was not posted:
Marked as duplicate.
3. frontend/src/container/FormAlertRules/ChannelSelect/index.tsx:49
- Draft comment:
Avoid using inline styles in React components. Instead, use external stylesheets, CSS classes, or styled components. This comment applies to other instances of inline styles in this file as well. - Reason this comment was not posted:
Marked as duplicate.
4. frontend/src/container/FormAlertRules/ChannelSelect/index.tsx:50
- Draft comment:
Avoid using inline styles in React components. Instead, use external stylesheets, CSS classes, or styled components. This comment applies to other instances of inline styles in this file as well. - Reason this comment was not posted:
Marked as duplicate.
5. frontend/src/container/FormAlertRules/ChannelSelect/index.tsx:51
- Draft comment:
Avoid using inline styles in React components. Instead, use external stylesheets, CSS classes, or styled components. This comment applies to other instances of inline styles in this file as well. - Reason this comment was not posted:
Marked as duplicate.
6. frontend/src/container/FormAlertRules/ChannelSelect/index.tsx:52
- Draft comment:
Avoid using inline styles in React components. Instead, use external stylesheets, CSS classes, or styled components. This comment applies to other instances of inline styles in this file as well. - Reason this comment was not posted:
Marked as duplicate.
7. frontend/src/container/FormAlertRules/ChannelSelect/index.tsx:53
- Draft comment:
Avoid using inline styles in React components. Instead, use external stylesheets, CSS classes, or styled components. This comment applies to other instances of inline styles in this file as well. - Reason this comment was not posted:
Marked as duplicate.
8. pkg/query-service/app/traces/v4/enrich.go:65
-
Draft comment:
Duplicate of existing functionEnrichTracesQuery
inpkg/query-service/app/traces/v3/query_builder.go
. Consider reusing the existing function. -
function
EnrichTracesQuery
(query_builder.go) -
Reason this comment was not posted:
Marked as duplicate.
Workflow ID: wflow_TTKTBOalJmck4vzV
Want Ellipsis to fix these issues? Tag @ellipsis-dev
in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Summary
Important
Update SigNoz to v0.58.2 with enhancements in trace handling, telemetry, and refactoring.
docker-compose.yaml
,docker-compose-minimal.yaml
, anddocker-compose.testing.yaml
.enrich.go
andenrich_test.go
for trace query enrichment inv4
.query_builder_test.go
to include new test cases for trace queries.anomalyBasedAlerts
to telemetry data intelemetry.go
.reader.go
andhttp_handler.go
.GetListTsRanges
inlogs.go
andlogs_test.go
.Dockerfile
to3.20.3
.useRef
inBasicInfo.tsx
to prevent duplicate event logging.refetchChannels
function inChannelSelect/index.tsx
.This description was created by for 9ccc686. It will automatically update as commits are pushed.