Release/v0.58.x

[prashant-shahi]

Summary

• release SigNoz v0.58.0
• bump up SigNoz OtelCollector v0.111.8

---

Important

Enhance template processing to support {{.Labels.service.name}} syntax and improve string escaping for ClickHouse queries, with comprehensive tests for backward compatibility.

• Template Processing:
  • Enhance preprocessTemplate() in rules/templates.go to handle {{.Labels.service.name}} syntax.
  • Add regex to replace {{.Labels.service.name}} with {{index .Labels "service.name"}}.
• String Escaping:
  • Modify QuoteEscapedStringForContains() in utils/format.go to handle index-specific escaping for ClickHouse queries.
• Testing:
  • Add test TestTemplateExpander_WithLablesDotSyntax in templates_test.go to verify new template syntax handling.
  • Ensure backward compatibility with existing template syntax through tests.

^{This description was created by for 48f3b9c. It will automatically update as commits are pushed.}

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
10 out of 11 committers have signed the CLA.

✅ eKuG
✅ YounixM
✅ vikrantgupta25
✅ srikanthccv
✅ nityanandagohain
✅ ankitnayan
✅ shivanshuraj1333
✅ ahmadshaheer
✅ prashant-shahi
✅ SagarRajput-7
❌ dependabot[bot]
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[github-actions]

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

[github-actions]

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

[ellipsis-dev]

❌ Changes requested. Reviewed everything up to 48f3b9c in 3 minutes and 4 seconds

More details

• Looked at 10839 lines of code in 135 files
• Skipped 1 files when reviewing.
• Skipped posting 7 drafted comments based on config settings.

1. pkg/query-service/app/inframetrics/namespaces.go:180

• Draft comment:
  The math.Min function returns a float64, but it is being used as an index for slicing, which requires an int. Consider casting the result to int to avoid potential type mismatch errors.
• Reason this comment was not posted:
  Comment looked like it was already resolved.

2. pkg/query-service/app/inframetrics/hosts.go:266

• Draft comment:
  Using math.Min for slice indices is incorrect because it returns a float64. Use integer comparison instead to determine the limit for slicing.
• Reason this comment was not posted:
  Marked as duplicate.

3. frontend/src/pages/MessagingQueues/MQDetails/MessagingQueueOverview.tsx:92

• Draft comment:
  Consider making the evaluation interval configurable or define it as a constant for better maintainability.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The code is using a hardcoded value for the evaluation interval in milliseconds. This should be configurable or at least documented as a constant for better maintainability.

4. frontend/src/pages/MessagingQueues/MQDetails/MessagingQueueOverview.tsx:88

• Draft comment:
  Consider parameterizing the evaluation time instead of using a hardcoded value (2363404 ms) to improve flexibility and maintainability.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The code is using a hardcoded value for the evaluation time in milliseconds. This should be parameterized or configurable to allow flexibility and avoid magic numbers.

5. frontend/src/pages/MessagingQueues/MQDetails/DropRateView/EvaluationTimeSelector.tsx:95

• Draft comment:
  Avoid using inline styles in React components. Use external stylesheets, CSS classes, or styled components instead.
• Reason this comment was not posted:
  Marked as duplicate.

6. frontend/src/pages/MessagingQueues/MQDetails/DropRateView/EvaluationTimeSelector.tsx:104

• Draft comment:
  Avoid using inline styles. Consider using CSS classes or styled components instead.
• Reason this comment was not posted:
  Marked as duplicate.

7. frontend/src/pages/MessagingQueues/MQDetails/DropRateView/EvaluationTimeSelector.tsx:92

• Draft comment:
  Avoid using inline styles in React components. Consider using CSS classes or styled components instead.
• Reason this comment was not posted:
  Marked as duplicate.

Workflow ID: wflow_5aKDGICftM4nBens

---

Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.