Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Argo Translation PR356 GITHUB-5157: [AE] Add/Restructure Olfactory Arts Categories #499

Open
wants to merge 60 commits into
base: main
Choose a base branch
from

Conversation

argo-translation-integration[bot]
Copy link
Contributor

Translation PR

This Translation PR contains translations of source language files modified #356, Argo Request GITHUB-5157. The contents of the source language files translated are after the files after the PR has been merged 7c52e4b, which is also the base commit of this PR's head branch.

The Argo CI Check will be neutral until all translations have been committed to Github, at which point it will succeed. You can check a detailed status of individual translations by commenting /argo -s in this PR.

⚠️ Merging from the base branch ⚠

If you intend to merge from the base branch into this PR, you must wait until all translations have been committed (Argo CI Check passes). Otherwise, any commits made by Argo will overwrite changes to those files on the base branch since the Original PR was merged.

What happens if I merge this before translation is done?

After merging, after another target language file is complete, Argo will force-push the branch ae-olfactory-arts-argo-pr356 to the merge commit of #356, commit the file to the branch, and then open a new Translation PR with the same name.

@argo-translation-integration
Copy link
Contributor Author

All translations from GITHUB-5157 have been committed. @ricardotejedorsanz

@contrebande-labs
Copy link

contrebande-labs commented Dec 19, 2024

Hi @ricardotejedorsanz ! I notice that the translations are of very poor quality. Are they going to be reviewed by humans?

Here are two examples in the category fr.yml:

ae-2-1-2-17-2-1:
      name: Ingrédients du parfum
      context: Arts & Entertainment > Hobbies & Creative Arts > Arts & Crafts > Art & Crafting Materials > Olfactory Arts Materials > Perfumery Ingredients > Fragrance Ingredients

Fragrance ingredients should translate in French as Ingrédients à parfumerie

But! Since bases are also fragrance ingredients, we refer to pure ingredients as raw materials, in french matériaux bruts.

Next example:

    ae-2-1-2-17-2-2:
      name: Socles
      context: Arts & Entertainment > Hobbies & Creative Arts > Arts & Crafts > Art & Crafting Materials > Olfactory Arts Materials > Perfumery Ingredients > Bases

Socles means pedestal in French. You can translate bases in the perfumery sense as bases in French. But the more correct word is Spécialités (in full: Spécialités de parfumerie). You can even say Specialties in English but this usage is less common.

Hope this helps. I'm not familiar with the other languages so I cannot help you with anything else than French and English.

@ricardotejedorsanz
Copy link
Contributor

Thanks @contrebande-labs! I agree that "socle" isn't the right term for this context. cc @aalexandreia @Carlotta-Stefanelli, could you please pass this feedback to the translators to ensure it fits the context of perfumer's bases? 🙏

data/localizations/attributes/zh-TW.yml
Argo Request GITHUB-5157
PR356
data/localizations/attributes/nb.yml
Argo Request GITHUB-5157
PR356
data/localizations/attributes/vi.yml
Argo Request GITHUB-5157
PR356
data/localizations/attributes/fr.yml
Argo Request GITHUB-5157
PR356
data/localizations/categories/vi.yml
Argo Request GITHUB-5157
PR356
data/localizations/attributes/cs.yml
Argo Request GITHUB-5157
PR356
data/localizations/attributes/ko.yml
Argo Request GITHUB-5157
PR356
data/localizations/categories/ko.yml
Argo Request GITHUB-5157
PR356
data/localizations/values/vi.yml
Argo Request GITHUB-5157
PR356
data/localizations/categories/zh-TW.yml
Argo Request GITHUB-5157
PR356
data/localizations/values/ko.yml
Argo Request GITHUB-5157
PR356
data/localizations/categories/nb.yml
Argo Request GITHUB-5157
PR356
data/localizations/attributes/pt-BR.yml
Argo Request GITHUB-5157
PR356
data/localizations/attributes/it.yml
Argo Request GITHUB-5157
PR356
data/localizations/categories/cs.yml
Argo Request GITHUB-5157
PR356
data/localizations/attributes/ja.yml
Argo Request GITHUB-5157
PR356
data/localizations/attributes/sv.yml
Argo Request GITHUB-5157
PR356
data/localizations/categories/nl.yml
Argo Request GITHUB-5157
PR356
data/localizations/attributes/pl.yml
Argo Request GITHUB-5157
PR356
data/localizations/categories/fr.yml
Argo Request GITHUB-5157
PR356
data/localizations/values/nb.yml
Argo Request GITHUB-5157
PR356
data/localizations/attributes/pt-PT.yml
Argo Request GITHUB-5157
PR356
data/localizations/categories/pt-BR.yml
Argo Request GITHUB-5157
PR356
data/localizations/values/da.yml
Argo Request GITHUB-5157
PR356
data/localizations/values/it.yml
Argo Request GITHUB-5157
PR356
data/localizations/categories/pl.yml
Argo Request GITHUB-5157
PR356
data/localizations/categories/pt-PT.yml
Argo Request GITHUB-5157
PR356
data/localizations/values/pt-BR.yml
Argo Request GITHUB-5157
PR356
data/localizations/values/zh-TW.yml
Argo Request GITHUB-5157
PR356
data/localizations/categories/ja.yml
Argo Request GITHUB-5157
PR356
data/localizations/attributes/da.yml
Argo Request GITHUB-5157
PR356
data/localizations/categories/da.yml
Argo Request GITHUB-5157
PR356
data/localizations/attributes/nl.yml
Argo Request GITHUB-5157
PR356
data/localizations/attributes/tr.yml
Argo Request GITHUB-5157
PR356
data/localizations/categories/tr.yml
Argo Request GITHUB-5157
PR356
data/localizations/categories/de.yml
Argo Request GITHUB-5157
PR356
data/localizations/values/pt-PT.yml
Argo Request GITHUB-5157
PR356
data/localizations/attributes/de.yml
Argo Request GITHUB-5157
PR356
data/localizations/categories/es.yml
Argo Request GITHUB-5157
PR356
data/localizations/values/fr.yml
Argo Request GITHUB-5157
PR356
data/localizations/values/pl.yml
Argo Request GITHUB-5157
PR356
data/localizations/values/cs.yml
Argo Request GITHUB-5157
PR356
data/localizations/categories/sv.yml
Argo Request GITHUB-5157
PR356
data/localizations/values/tr.yml
Argo Request GITHUB-5157
PR356
data/localizations/values/nl.yml
Argo Request GITHUB-5157
PR356
data/localizations/values/es.yml
Argo Request GITHUB-5157
PR356
data/localizations/values/sv.yml
Argo Request GITHUB-5157
PR356
data/localizations/values/de.yml
Argo Request GITHUB-5157
PR356
@aalexandreia
Copy link

Thank you for your valuable input @contrebande-labs! We've raised the quality concerns with our vendor and we're working on a fix for the flagged terms. cc. @ricardotejedorsanz @MRodriguezRod

@aalexandreia aalexandreia self-assigned this Dec 19, 2024
@contrebande-labs
Copy link

Thanks guys!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants