Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Web Redemption Links #1227

Merged
merged 3 commits into from
Dec 20, 2024
Merged

Support Web Redemption Links #1227

merged 3 commits into from
Dec 20, 2024

Conversation

tonidero
Copy link
Contributor

This adds support for Web Redemption Links in our Flutter SDK.

@tonidero tonidero added the pr:feat A new feature label Dec 17, 2024
Copy link
Contributor Author

@tonidero tonidero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the big diff, but more than half is actually generated code, so it should hopefully not be as bad as it looks 🙏

@@ -0,0 +1,875 @@
// coverage:ignore-file
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is generated code by freezed, no need to review it!

@@ -13,6 +13,8 @@ dependencies:
# Use with the CupertinoIcons class for iOS style icons.
cupertino_icons: ^1.0.4

app_links: ^6.3.3
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this library to read the deep links. Seemed one of the simpler ones.

@tonidero tonidero marked this pull request as ready for review December 17, 2024 17:10
@tonidero tonidero requested review from a team December 17, 2024 17:11
Copy link
Contributor

@vegaro vegaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! I think this solution will just work fine with any deeplinking library

@tonidero tonidero merged commit f58fbd4 into main Dec 20, 2024
8 checks passed
@tonidero tonidero deleted the support-web-redemption-links branch December 20, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:feat A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants