Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimized main workflow, updated code ownership to Redot-Engine #652

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

dandykong
Copy link

The main GitHub Actions workflow now has a workflow_dispatch event trigger and no longer autoruns on non-master pushes. This allows contributors to run checks on-demand without causing the expensive builds to automatically run on every commit for the entire lifetime of their fork.

The codeowner file no longer references Godot's GitHub organization. By default, any public Redot-Engine teams created with the same name will automatically be assigned the corresponding files.

@SkogiB
Copy link
Contributor

SkogiB commented Oct 10, 2024

Engine dev chat has been discussing it and we're not sure where we sit on the runner change, and the codeowners change we feel is superfluous given how small the crew is right now, but we're leaving it open in case we come to a more rigid decision later and we don't want to leave you totally in limbo

on:
push:
branches:
- master
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Spartan322 Spartan322 added rebranding issues and pr's related to engine rebranding topic:buildsystem labels Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rebranding issues and pr's related to engine rebranding topic:buildsystem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants