Add an --app= flag for specifying the WSGI application #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merwok
reviewed
Nov 25, 2024
The dunder attributes shouldn't really be touched directly, and if something else is already capturing these streams, this method is less likely to mess things up.
I somehow had it in my head that this was some leftover debug code I'd written, but it's not. it was introduced back in Pylons#102. With that in mind, I've restored it _functionally_, but it now leans on the `traceback` to print a stacktrace instead.
|
@mmerickel If you get a chance, I appreciate a review from another maintainer! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is essentially a less-invasive version of #441. As with that PR, this PR adds support for a
--appflag for specifying the WSGI app to run. Unlike that one, it maintains the getopt-based implementation. There's certainly some value in moving to argparse at some point, but it'd need to integrate properly with theAdjustmentsclass.Closes #439, closes #441.
Some incidental changes that grew out of this:
capture()context manager is now more well-behaved as it respects the previous values ofsys.stderrandsys.stdin, and restores them in afinallyblock if there's an exception.Adjustments.parse_cli()is now responsible for resolving the app descriptor. This forces some of the tests to be a bit more realistic.show_exception, while leaning on the standard library more.