Cache Images for faster parsing subsequent images (or frames in animation) #396 #398
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loading large images during parsing can take ages. When rendering animations these images are reloaded before rendering each frame.
With this solution the images are only loaded once and cached for reuse when parsing the next frame. This can dramatically decrease parsing time.
Be free to point out any errors, this is my first serious C++ code written ever (normally I do C#).
The code has been tested and I don't see any significant memory leakage, in fact I am already using this in production (and it is saving lots of resources!).
I asked for this feature in issue #395 , instead of waiting for it I embarked on this rewarding quest.