Use a more efficient `enable_if_t` implementation #3071

miscco · 2024-12-06T09:57:22Z

This optimizes our enable_if_t implementation, which is one of the most commonly used types in the whole repository

Rather than instantiating a type for every occurence we instantiate the type only twice

bernhardmgruber · 2024-12-06T12:37:03Z

libcudacxx/include/cuda/std/__mdspan/layout_stride.h

+      typename enable_if<_CCCL_TRAIT(is_convertible, const remove_const_t<_IntegralTypes>&, index_type), int>::type = 0,
+      typename enable_if<_CCCL_TRAIT(is_nothrow_constructible, index_type, const remove_const_t<_IntegralTypes>&),
+                         int>::type                                                                                 = 0>


Q: Why isn't this using enable_if_t? What bug is worked around here?

Yeah layout_stride cannot deduce its arguments if we use the enable_if_t 🤷

That said, we seem to have more issues like this

Sad. Consider adding a comment for those cases, so nobody is tempted to rewrite a enable_if<...>::type into enable_if_t and needs a whole CI run to find out it's a bug.

github-actions · 2024-12-06T14:20:53Z

🟨 CI finished in 1h 43m: Pass: 94%/168 | Total: 3d 03h | Avg: 26m 58s | Max: 1h 15m | Hits: 71%/17422

🟨 libcudacxx: Pass: 79%/48 | Total: 14h 02m | Avg: 17m 33s | Max: 1h 06m | Hits: 32%/4822

🔍 cpu: amd64 🔍
  🔍 amd64              Pass:  78%/46  | Total: 13h 19m | Avg: 17m 22s | Max:  1h 06m | Hits:  32%/4822  
  🟩 arm64              Pass: 100%/2   | Total: 43m 14s | Avg: 21m 37s | Max: 23m 03s
🔍 cudacxx_family: nvcc 🔍
  🟩 ClangCUDA          Pass: 100%/4   | Total: 59m 56s | Avg: 14m 59s | Max: 18m 57s
  🔍 nvcc               Pass:  77%/44  | Total: 13h 02m | Avg: 17m 47s | Max:  1h 06m | Hits:  32%/4822  
🔍 std: 17 🔍
  🟩 11                 Pass: 100%/6   | Total: 36m 47s | Avg:  6m 07s | Max: 21m 38s
  🟩 14                 Pass: 100%/5   | Total:  1h 19m | Avg: 15m 53s | Max: 30m 39s | Hits:  34%/2213  
  🔍 17                 Pass:  23%/13  | Total:  3h 56m | Avg: 18m 11s | Max: 30m 10s
  🟩 20                 Pass: 100%/23  | Total:  8h 07m | Avg: 21m 12s | Max:  1h 06m | Hits:  30%/2609  
🟨 ctk
  🟨 11.1               Pass:  71%/7   | Total:  1h 11m | Avg: 10m 15s | Max: 30m 39s | Hits:  34%/2213  
  🟩 12.5               Pass: 100%/2   | Total: 57m 45s | Avg: 28m 52s | Max: 29m 48s
  🟨 12.6               Pass:  79%/39  | Total: 11h 53m | Avg: 18m 16s | Max:  1h 06m | Hits:  30%/2609  
🟨 cudacxx
  🟩 ClangCUDA18        Pass: 100%/4   | Total: 59m 56s | Avg: 14m 59s | Max: 18m 57s
  🟨 nvcc11.1           Pass:  71%/7   | Total:  1h 11m | Avg: 10m 15s | Max: 30m 39s | Hits:  34%/2213  
  🟩 nvcc12.5           Pass: 100%/2   | Total: 57m 45s | Avg: 28m 52s | Max: 29m 48s
  🟨 nvcc12.6           Pass:  77%/35  | Total: 10h 53m | Avg: 18m 39s | Max:  1h 06m | Hits:  30%/2609  
🟨 cxx
  🟨 Clang9             Pass:  75%/4   | Total: 39m 04s | Avg:  9m 46s | Max: 16m 45s
  🟥 Clang10            Pass:   0%/1   | Total:  5m 55s | Avg:  5m 55s | Max:  5m 55s
  🟩 Clang11            Pass: 100%/1   | Total: 21m 14s | Avg: 21m 14s | Max: 21m 14s
  🟩 Clang12            Pass: 100%/1   | Total: 19m 10s | Avg: 19m 10s | Max: 19m 10s
  🟩 Clang13            Pass: 100%/1   | Total:  4m 28s | Avg:  4m 28s | Max:  4m 28s
  🟩 Clang14            Pass: 100%/1   | Total: 20m 37s | Avg: 20m 37s | Max: 20m 37s
  🟩 Clang15            Pass: 100%/1   | Total:  5m 15s | Avg:  5m 15s | Max:  5m 15s
  🟩 Clang16            Pass: 100%/1   | Total: 23m 47s | Avg: 23m 47s | Max: 23m 47s
  🟩 Clang17            Pass: 100%/1   | Total: 20m 50s | Avg: 20m 50s | Max: 20m 50s
  🟨 Clang18            Pass:  87%/8   | Total:  2h 18m | Avg: 17m 17s | Max: 20m 50s
  🟩 GCC6               Pass: 100%/2   | Total:  5m 28s | Avg:  2m 44s | Max:  3m 08s
  🟩 GCC7               Pass: 100%/2   | Total:  6m 32s | Avg:  3m 16s | Max:  3m 36s
  🟥 GCC8               Pass:   0%/1   | Total: 18m 49s | Avg: 18m 49s | Max: 18m 49s
  🟨 GCC9               Pass:  33%/3   | Total: 38m 44s | Avg: 12m 54s | Max: 21m 13s
  🟩 GCC10              Pass: 100%/1   | Total: 19m 59s | Avg: 19m 59s | Max: 19m 59s
  🟩 GCC11              Pass: 100%/1   | Total: 20m 51s | Avg: 20m 51s | Max: 20m 51s
  🟩 GCC12              Pass: 100%/1   | Total: 23m 11s | Avg: 23m 11s | Max: 23m 11s
  🟨 GCC13              Pass:  80%/10  | Total:  3h 40m | Avg: 22m 01s | Max:  1h 06m
  🟩 Intel2023.2.0      Pass: 100%/1   | Total: 22m 37s | Avg: 22m 37s | Max: 22m 37s
  🟩 MSVC14.16          Pass: 100%/1   | Total: 30m 39s | Avg: 30m 39s | Max: 30m 39s | Hits:  34%/2213  
  🟥 MSVC14.29          Pass:   0%/1   | Total: 30m 10s | Avg: 30m 10s | Max: 30m 10s
  🟨 MSVC14.39          Pass:  50%/2   | Total: 48m 54s | Avg: 24m 27s | Max: 35m 03s | Hits:  30%/2609  
  🟩 NVHPC24.7          Pass: 100%/2   | Total: 57m 45s | Avg: 28m 52s | Max: 29m 48s
🟨 cxx_family
  🟨 Clang              Pass:  85%/20  | Total:  4h 58m | Avg: 14m 56s | Max: 23m 47s
  🟨 GCC                Pass:  76%/21  | Total:  5h 53m | Avg: 16m 50s | Max:  1h 06m
  🟩 Intel              Pass: 100%/1   | Total: 22m 37s | Avg: 22m 37s | Max: 22m 37s
  🟨 MSVC               Pass:  50%/4   | Total:  1h 49m | Avg: 27m 25s | Max: 35m 03s | Hits:  32%/4822  
  🟩 NVHPC              Pass: 100%/2   | Total: 57m 45s | Avg: 28m 52s | Max: 29m 48s
🟨 jobs
  🟨 Build              Pass:  78%/41  | Total: 10h 58m | Avg: 16m 04s | Max: 35m 03s | Hits:  32%/4822  
  🟨 NVRTC              Pass:  75%/4   | Total:  1h 37m | Avg: 24m 29s | Max: 26m 27s
  🟩 Test               Pass: 100%/2   | Total:  1h 23m | Avg: 41m 58s | Max:  1h 06m
  🟩 VerifyCodegen      Pass: 100%/1   | Total:  1m 58s | Avg:  1m 58s | Max:  1m 58s
🟨 gpu
  🟨 v100               Pass:  79%/48  | Total: 14h 02m | Avg: 17m 33s | Max:  1h 06m | Hits:  32%/4822  
🟩 sm
  🟩 90                 Pass: 100%/1   | Total: 11m 59s | Avg: 11m 59s | Max: 11m 59s
  🟩 90a                Pass: 100%/2   | Total: 15m 45s | Avg:  7m 52s | Max: 11m 42s

🟩 thrust: Pass: 100%/46 | Total: 21h 31m | Avg: 28m 04s | Max: 1h 07m | Hits: 90%/9260

🟩 cmake_options
  🟩 -DTHRUST_DISPATCH_TYPE=Force32bit Pass: 100%/2   | Total: 45m 13s | Avg: 22m 36s | Max: 30m 05s
🟩 cpu
  🟩 amd64              Pass: 100%/44  | Total: 20h 25m | Avg: 27m 51s | Max:  1h 07m | Hits:  90%/9260  
  🟩 arm64              Pass: 100%/2   | Total:  1h 05m | Avg: 32m 36s | Max: 34m 47s
🟩 ctk
  🟩 11.1               Pass: 100%/7   | Total:  2h 21m | Avg: 20m 12s | Max: 30m 19s | Hits:  99%/1852  
  🟩 12.5               Pass: 100%/2   | Total:  1h 41m | Avg: 50m 59s | Max: 51m 21s
  🟩 12.6               Pass: 100%/37  | Total: 17h 27m | Avg: 28m 19s | Max:  1h 07m | Hits:  88%/7408  
🟩 cudacxx
  🟩 ClangCUDA18        Pass: 100%/2   | Total:  1h 00m | Avg: 30m 02s | Max: 31m 11s
  🟩 nvcc11.1           Pass: 100%/7   | Total:  2h 21m | Avg: 20m 12s | Max: 30m 19s | Hits:  99%/1852  
  🟩 nvcc12.5           Pass: 100%/2   | Total:  1h 41m | Avg: 50m 59s | Max: 51m 21s
  🟩 nvcc12.6           Pass: 100%/35  | Total: 16h 27m | Avg: 28m 13s | Max:  1h 07m | Hits:  88%/7408  
🟩 cudacxx_family
  🟩 ClangCUDA          Pass: 100%/2   | Total:  1h 00m | Avg: 30m 02s | Max: 31m 11s
  🟩 nvcc               Pass: 100%/44  | Total: 20h 31m | Avg: 27m 58s | Max:  1h 07m | Hits:  90%/9260  
🟩 cxx
  🟩 Clang9             Pass: 100%/4   | Total:  1h 10m | Avg: 17m 37s | Max: 30m 46s
  🟩 Clang10            Pass: 100%/1   | Total: 33m 53s | Avg: 33m 53s | Max: 33m 53s
  🟩 Clang11            Pass: 100%/1   | Total: 31m 38s | Avg: 31m 38s | Max: 31m 38s
  🟩 Clang12            Pass: 100%/1   | Total: 32m 15s | Avg: 32m 15s | Max: 32m 15s
  🟩 Clang13            Pass: 100%/1   | Total: 30m 47s | Avg: 30m 47s | Max: 30m 47s
  🟩 Clang14            Pass: 100%/1   | Total: 32m 03s | Avg: 32m 03s | Max: 32m 03s
  🟩 Clang15            Pass: 100%/1   | Total: 33m 23s | Avg: 33m 23s | Max: 33m 23s
  🟩 Clang16            Pass: 100%/1   | Total: 32m 28s | Avg: 32m 28s | Max: 32m 28s
  🟩 Clang17            Pass: 100%/1   | Total: 32m 24s | Avg: 32m 24s | Max: 32m 24s
  🟩 Clang18            Pass: 100%/7   | Total:  2h 57m | Avg: 25m 21s | Max: 31m 50s
  🟩 GCC6               Pass: 100%/2   | Total: 55m 42s | Avg: 27m 51s | Max: 29m 00s
  🟩 GCC7               Pass: 100%/2   | Total: 35m 14s | Avg: 17m 37s | Max: 30m 30s
  🟩 GCC8               Pass: 100%/1   | Total: 36m 18s | Avg: 36m 18s | Max: 36m 18s
  🟩 GCC9               Pass: 100%/3   | Total:  1h 07m | Avg: 22m 39s | Max: 34m 20s
  🟩 GCC10              Pass: 100%/1   | Total: 34m 17s | Avg: 34m 17s | Max: 34m 17s
  🟩 GCC11              Pass: 100%/1   | Total: 33m 42s | Avg: 33m 42s | Max: 33m 42s
  🟩 GCC12              Pass: 100%/1   | Total: 34m 52s | Avg: 34m 52s | Max: 34m 52s
  🟩 GCC13              Pass: 100%/8   | Total:  3h 22m | Avg: 25m 20s | Max: 39m 50s
  🟩 Intel2023.2.0      Pass: 100%/1   | Total: 42m 34s | Avg: 42m 34s | Max: 42m 34s
  🟩 MSVC14.16          Pass: 100%/1   | Total: 17m 40s | Avg: 17m 40s | Max: 17m 40s | Hits:  99%/1852  
  🟩 MSVC14.29          Pass: 100%/1   | Total: 16m 41s | Avg: 16m 41s | Max: 16m 41s | Hits:  99%/1852  
  🟩 MSVC14.39          Pass: 100%/3   | Total:  1h 44m | Avg: 34m 52s | Max:  1h 07m | Hits:  85%/5556  
  🟩 NVHPC24.7          Pass: 100%/2   | Total:  1h 41m | Avg: 50m 59s | Max: 51m 21s
🟩 cxx_family
  🟩 Clang              Pass: 100%/19  | Total:  8h 26m | Avg: 26m 40s | Max: 33m 53s
  🟩 GCC                Pass: 100%/19  | Total:  8h 20m | Avg: 26m 21s | Max: 39m 50s
  🟩 Intel              Pass: 100%/1   | Total: 42m 34s | Avg: 42m 34s | Max: 42m 34s
  🟩 MSVC               Pass: 100%/5   | Total:  2h 18m | Avg: 27m 47s | Max:  1h 07m | Hits:  90%/9260  
  🟩 NVHPC              Pass: 100%/2   | Total:  1h 41m | Avg: 50m 59s | Max: 51m 21s
🟩 gpu
  🟩 v100               Pass: 100%/46  | Total: 21h 31m | Avg: 28m 04s | Max:  1h 07m | Hits:  90%/9260  
🟩 jobs
  🟩 Build              Pass: 100%/40  | Total: 20h 08m | Avg: 30m 13s | Max:  1h 07m | Hits:  88%/7408  
  🟩 TestCPU            Pass: 100%/3   | Total: 37m 25s | Avg: 12m 28s | Max: 20m 53s | Hits:  99%/1852  
  🟩 TestGPU            Pass: 100%/3   | Total: 44m 59s | Avg: 14m 59s | Max: 16m 29s
🟩 sm
  🟩 90a                Pass: 100%/1   | Total: 22m 47s | Avg: 22m 47s | Max: 22m 47s
🟩 std
  🟩 11                 Pass: 100%/5   | Total: 44m 46s | Avg:  8m 57s | Max: 26m 42s
  🟩 14                 Pass: 100%/4   | Total:  1h 47m | Avg: 26m 59s | Max: 30m 46s | Hits:  99%/1852  
  🟩 17                 Pass: 100%/12  | Total:  6h 28m | Avg: 32m 24s | Max: 50m 38s | Hits:  99%/3704  
  🟩 20                 Pass: 100%/23  | Total: 11h 44m | Avg: 30m 37s | Max:  1h 07m | Hits:  78%/3704

🟩 cub: Pass: 100%/45 | Total: 1d 09h | Avg: 44m 57s | Max: 1h 15m | Hits: 75%/3028

🟩 cpu
  🟩 amd64              Pass: 100%/43  | Total:  1d 07h | Avg: 44m 18s | Max:  1h 15m | Hits:  75%/3028  
  🟩 arm64              Pass: 100%/2   | Total:  1h 57m | Avg: 58m 53s | Max:  1h 00m
🟩 ctk
  🟩 11.1               Pass: 100%/7   | Total:  3h 00m | Avg: 25m 47s | Max: 52m 04s | Hits:  99%/757   
  🟩 12.5               Pass: 100%/2   | Total:  2h 15m | Avg:  1h 07m | Max:  1h 11m
  🟩 12.6               Pass: 100%/36  | Total:  1d 04h | Avg: 47m 24s | Max:  1h 15m | Hits:  67%/2271  
🟩 cudacxx
  🟩 ClangCUDA18        Pass: 100%/2   | Total:  2h 01m | Avg:  1h 00m | Max:  1h 01m
  🟩 nvcc11.1           Pass: 100%/7   | Total:  3h 00m | Avg: 25m 47s | Max: 52m 04s | Hits:  99%/757   
  🟩 nvcc12.5           Pass: 100%/2   | Total:  2h 15m | Avg:  1h 07m | Max:  1h 11m
  🟩 nvcc12.6           Pass: 100%/34  | Total:  1d 02h | Avg: 46m 37s | Max:  1h 15m | Hits:  67%/2271  
🟩 cudacxx_family
  🟩 ClangCUDA          Pass: 100%/2   | Total:  2h 01m | Avg:  1h 00m | Max:  1h 01m
  🟩 nvcc               Pass: 100%/43  | Total:  1d 07h | Avg: 44m 13s | Max:  1h 15m | Hits:  75%/3028  
🟩 cxx
  🟩 Clang9             Pass: 100%/4   | Total:  2h 02m | Avg: 30m 31s | Max: 57m 21s
  🟩 Clang10            Pass: 100%/1   | Total: 54m 31s | Avg: 54m 31s | Max: 54m 31s
  🟩 Clang11            Pass: 100%/1   | Total: 53m 44s | Avg: 53m 44s | Max: 53m 44s
  🟩 Clang12            Pass: 100%/1   | Total: 55m 50s | Avg: 55m 50s | Max: 55m 50s
  🟩 Clang13            Pass: 100%/1   | Total: 56m 56s | Avg: 56m 56s | Max: 56m 56s
  🟩 Clang14            Pass: 100%/1   | Total: 55m 37s | Avg: 55m 37s | Max: 55m 37s
  🟩 Clang15            Pass: 100%/1   | Total: 55m 20s | Avg: 55m 20s | Max: 55m 20s
  🟩 Clang16            Pass: 100%/1   | Total: 54m 15s | Avg: 54m 15s | Max: 54m 15s
  🟩 Clang17            Pass: 100%/1   | Total:  1h 15m | Avg:  1h 15m | Max:  1h 15m
  🟩 Clang18            Pass: 100%/7   | Total:  5h 59m | Avg: 51m 18s | Max:  1h 01m
  🟩 GCC6               Pass: 100%/2   | Total: 55m 01s | Avg: 27m 30s | Max: 51m 03s
  🟩 GCC7               Pass: 100%/2   | Total:  1h 02m | Avg: 31m 22s | Max: 53m 37s
  🟩 GCC8               Pass: 100%/1   | Total: 53m 21s | Avg: 53m 21s | Max: 53m 21s
  🟩 GCC9               Pass: 100%/3   | Total:  1h 54m | Avg: 38m 14s | Max: 58m 44s
  🟩 GCC10              Pass: 100%/1   | Total:  1h 01m | Avg:  1h 01m | Max:  1h 01m
  🟩 GCC11              Pass: 100%/1   | Total:  1h 02m | Avg:  1h 02m | Max:  1h 02m
  🟩 GCC12              Pass: 100%/1   | Total: 58m 44s | Avg: 58m 44s | Max: 58m 44s
  🟩 GCC13              Pass: 100%/8   | Total:  5h 12m | Avg: 39m 05s | Max: 59m 12s
  🟩 Intel2023.2.0      Pass: 100%/1   | Total: 59m 23s | Avg: 59m 23s | Max: 59m 23s
  🟩 MSVC14.16          Pass: 100%/1   | Total: 14m 32s | Avg: 14m 32s | Max: 14m 32s | Hits:  99%/757   
  🟩 MSVC14.29          Pass: 100%/1   | Total: 11m 42s | Avg: 11m 42s | Max: 11m 42s | Hits:  99%/757   
  🟩 MSVC14.39          Pass: 100%/2   | Total:  1h 16m | Avg: 38m 18s | Max:  1h 04m | Hits:  51%/1514  
  🟩 NVHPC24.7          Pass: 100%/2   | Total:  2h 15m | Avg:  1h 07m | Max:  1h 11m
🟩 cxx_family
  🟩 Clang              Pass: 100%/19  | Total: 15h 43m | Avg: 49m 39s | Max:  1h 15m
  🟩 GCC                Pass: 100%/19  | Total: 13h 01m | Avg: 41m 08s | Max:  1h 02m
  🟩 Intel              Pass: 100%/1   | Total: 59m 23s | Avg: 59m 23s | Max: 59m 23s
  🟩 MSVC               Pass: 100%/4   | Total:  1h 42m | Avg: 25m 42s | Max:  1h 04m | Hits:  75%/3028  
  🟩 NVHPC              Pass: 100%/2   | Total:  2h 15m | Avg:  1h 07m | Max:  1h 11m
🟩 gpu
  🟩 v100               Pass: 100%/45  | Total:  1d 09h | Avg: 44m 57s | Max:  1h 15m | Hits:  75%/3028  
🟩 jobs
  🟩 Build              Pass: 100%/39  | Total:  1d 06h | Avg: 47m 27s | Max:  1h 15m | Hits:  75%/3028  
  🟩 DeviceLaunch       Pass: 100%/1   | Total: 17m 06s | Avg: 17m 06s | Max: 17m 06s
  🟩 GraphCapture       Pass: 100%/1   | Total: 15m 53s | Avg: 15m 53s | Max: 15m 53s
  🟩 HostLaunch         Pass: 100%/2   | Total:  1h 04m | Avg: 32m 27s | Max: 34m 57s
  🟩 TestGPU            Pass: 100%/2   | Total:  1h 13m | Avg: 36m 56s | Max: 45m 37s
🟩 sm
  🟩 90a                Pass: 100%/1   | Total: 25m 48s | Avg: 25m 48s | Max: 25m 48s
🟩 std
  🟩 11                 Pass: 100%/5   | Total: 31m 25s | Avg:  6m 17s | Max:  9m 48s
  🟩 14                 Pass: 100%/4   | Total:  2h 56m | Avg: 44m 08s | Max: 57m 21s | Hits:  99%/757   
  🟩 17                 Pass: 100%/12  | Total:  9h 55m | Avg: 49m 38s | Max:  1h 04m | Hits:  99%/1514  
  🟩 20                 Pass: 100%/24  | Total: 20h 19m | Avg: 50m 47s | Max:  1h 15m | Hits:   3%/757

🟩 cudax: Pass: 100%/26 | Total: 5h 38m | Avg: 13m 01s | Max: 19m 20s | Hits: 64%/312

🟩 cpu
  🟩 amd64              Pass: 100%/22  | Total:  4h 47m | Avg: 13m 05s | Max: 19m 20s | Hits:  64%/312   
  🟩 arm64              Pass: 100%/4   | Total: 50m 34s | Avg: 12m 38s | Max: 14m 00s
🟩 ctk
  🟩 12.0               Pass: 100%/3   | Total: 34m 16s | Avg: 11m 25s | Max: 12m 29s | Hits:  64%/156   
  🟩 12.5               Pass: 100%/2   | Total: 15m 52s | Avg:  7m 56s | Max:  8m 18s
  🟩 12.6               Pass: 100%/21  | Total:  4h 48m | Avg: 13m 43s | Max: 19m 20s | Hits:  64%/156   
🟩 cudacxx
  🟩 nvcc12.0           Pass: 100%/3   | Total: 34m 16s | Avg: 11m 25s | Max: 12m 29s | Hits:  64%/156   
  🟩 nvcc12.5           Pass: 100%/2   | Total: 15m 52s | Avg:  7m 56s | Max:  8m 18s
  🟩 nvcc12.6           Pass: 100%/21  | Total:  4h 48m | Avg: 13m 43s | Max: 19m 20s | Hits:  64%/156   
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/26  | Total:  5h 38m | Avg: 13m 01s | Max: 19m 20s | Hits:  64%/312   
🟩 cxx
  🟩 Clang9             Pass: 100%/1   | Total: 11m 26s | Avg: 11m 26s | Max: 11m 26s
  🟩 Clang10            Pass: 100%/1   | Total: 13m 15s | Avg: 13m 15s | Max: 13m 15s
  🟩 Clang11            Pass: 100%/1   | Total: 13m 48s | Avg: 13m 48s | Max: 13m 48s
  🟩 Clang12            Pass: 100%/1   | Total: 12m 36s | Avg: 12m 36s | Max: 12m 36s
  🟩 Clang13            Pass: 100%/1   | Total: 12m 23s | Avg: 12m 23s | Max: 12m 23s
  🟩 Clang14            Pass: 100%/1   | Total: 12m 25s | Avg: 12m 25s | Max: 12m 25s
  🟩 Clang15            Pass: 100%/1   | Total: 15m 26s | Avg: 15m 26s | Max: 15m 26s
  🟩 Clang16            Pass: 100%/1   | Total: 15m 38s | Avg: 15m 38s | Max: 15m 38s
  🟩 Clang17            Pass: 100%/1   | Total: 14m 10s | Avg: 14m 10s | Max: 14m 10s
  🟩 Clang18            Pass: 100%/4   | Total: 57m 01s | Avg: 14m 15s | Max: 18m 05s
  🟩 GCC9               Pass: 100%/1   | Total: 12m 29s | Avg: 12m 29s | Max: 12m 29s
  🟩 GCC10              Pass: 100%/1   | Total: 15m 13s | Avg: 15m 13s | Max: 15m 13s
  🟩 GCC11              Pass: 100%/1   | Total: 14m 52s | Avg: 14m 52s | Max: 14m 52s
  🟩 GCC12              Pass: 100%/2   | Total: 34m 14s | Avg: 17m 07s | Max: 19m 20s
  🟩 GCC13              Pass: 100%/4   | Total: 47m 02s | Avg: 11m 45s | Max: 14m 00s
  🟩 MSVC14.36          Pass: 100%/1   | Total: 10m 21s | Avg: 10m 21s | Max: 10m 21s | Hits:  64%/156   
  🟩 MSVC14.39          Pass: 100%/1   | Total: 10m 15s | Avg: 10m 15s | Max: 10m 15s | Hits:  64%/156   
  🟩 NVHPC24.7          Pass: 100%/2   | Total: 15m 52s | Avg:  7m 56s | Max:  8m 18s
🟩 cxx_family
  🟩 Clang              Pass: 100%/13  | Total:  2h 58m | Avg: 13m 42s | Max: 18m 05s
  🟩 GCC                Pass: 100%/9   | Total:  2h 03m | Avg: 13m 45s | Max: 19m 20s
  🟩 MSVC               Pass: 100%/2   | Total: 20m 36s | Avg: 10m 18s | Max: 10m 21s | Hits:  64%/312   
  🟩 NVHPC              Pass: 100%/2   | Total: 15m 52s | Avg:  7m 56s | Max:  8m 18s
🟩 gpu
  🟩 v100               Pass: 100%/26  | Total:  5h 38m | Avg: 13m 01s | Max: 19m 20s | Hits:  64%/312   
🟩 jobs
  🟩 Build              Pass: 100%/24  | Total:  5h 01m | Avg: 12m 32s | Max: 15m 38s | Hits:  64%/312   
  🟩 Test               Pass: 100%/2   | Total: 37m 25s | Avg: 18m 42s | Max: 19m 20s
🟩 sm
  🟩 90                 Pass: 100%/1   | Total:  9m 39s | Avg:  9m 39s | Max:  9m 39s
  🟩 90a                Pass: 100%/1   | Total: 11m 17s | Avg: 11m 17s | Max: 11m 17s
🟩 std
  🟩 17                 Pass: 100%/6   | Total:  1h 04m | Avg: 10m 47s | Max: 12m 29s
  🟩 20                 Pass: 100%/20  | Total:  4h 33m | Avg: 13m 41s | Max: 19m 20s | Hits:  64%/312

🟩 cccl_c_parallel: Pass: 100%/2 | Total: 12m 27s | Avg: 6m 13s | Max: 10m 05s

🟩 cpu
  🟩 amd64              Pass: 100%/2   | Total: 12m 27s | Avg:  6m 13s | Max: 10m 05s
🟩 ctk
  🟩 12.6               Pass: 100%/2   | Total: 12m 27s | Avg:  6m 13s | Max: 10m 05s
🟩 cudacxx
  🟩 nvcc12.6           Pass: 100%/2   | Total: 12m 27s | Avg:  6m 13s | Max: 10m 05s
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/2   | Total: 12m 27s | Avg:  6m 13s | Max: 10m 05s
🟩 cxx
  🟩 GCC13              Pass: 100%/2   | Total: 12m 27s | Avg:  6m 13s | Max: 10m 05s
🟩 cxx_family
  🟩 GCC                Pass: 100%/2   | Total: 12m 27s | Avg:  6m 13s | Max: 10m 05s
🟩 gpu
  🟩 v100               Pass: 100%/2   | Total: 12m 27s | Avg:  6m 13s | Max: 10m 05s
🟩 jobs
  🟩 Build              Pass: 100%/1   | Total:  2m 22s | Avg:  2m 22s | Max:  2m 22s
  🟩 Test               Pass: 100%/1   | Total: 10m 05s | Avg: 10m 05s | Max: 10m 05s

🟩 python: Pass: 100%/1 | Total: 23m 53s | Avg: 23m 53s | Max: 23m 53s

🟩 cpu
  🟩 amd64              Pass: 100%/1   | Total: 23m 53s | Avg: 23m 53s | Max: 23m 53s
🟩 ctk
  🟩 12.6               Pass: 100%/1   | Total: 23m 53s | Avg: 23m 53s | Max: 23m 53s
🟩 cudacxx
  🟩 nvcc12.6           Pass: 100%/1   | Total: 23m 53s | Avg: 23m 53s | Max: 23m 53s
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/1   | Total: 23m 53s | Avg: 23m 53s | Max: 23m 53s
🟩 cxx
  🟩 GCC13              Pass: 100%/1   | Total: 23m 53s | Avg: 23m 53s | Max: 23m 53s
🟩 cxx_family
  🟩 GCC                Pass: 100%/1   | Total: 23m 53s | Avg: 23m 53s | Max: 23m 53s
🟩 gpu
  🟩 v100               Pass: 100%/1   | Total: 23m 53s | Avg: 23m 53s | Max: 23m 53s
🟩 jobs
  🟩 Test               Pass: 100%/1   | Total: 23m 53s | Avg: 23m 53s | Max: 23m 53s

👃 Inspect Changes

Modifications in project?

	Project
	CCCL Infrastructure
+/-	libcu++
	CUB
	Thrust
	CUDA Experimental
	python
	CCCL C Parallel Library
	Catch2Helper

Modifications in project or dependencies?

	Project
	CCCL Infrastructure
+/-	libcu++
+/-	CUB
+/-	Thrust
+/-	CUDA Experimental
+/-	python
+/-	CCCL C Parallel Library
+/-	Catch2Helper

🏃‍ Runner counts (total jobs: 168)

#	Runner
124	`linux-amd64-cpu16`
19	`linux-amd64-gpu-v100-latest-1`
15	`windows-amd64-cpu16`
10	`linux-arm64-cpu16`

miscco requested review from a team as code owners December 6, 2024 09:57

miscco requested review from ericniebler and fbusato December 6, 2024 09:57

Use a more efficient enable_if_t implementation

77af435

miscco force-pushed the optimize_enable_if branch from 1dff3db to 77af435 Compare December 6, 2024 09:57

bernhardmgruber approved these changes Dec 6, 2024

View reviewed changes

Work around mdspan bug

0923df6

bernhardmgruber reviewed Dec 6, 2024

View reviewed changes

miscco added the bug:compiler A bug that requires compiler fixes label Dec 16, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use a more efficient `enable_if_t` implementation #3071

Use a more efficient `enable_if_t` implementation #3071

miscco commented Dec 6, 2024

bernhardmgruber Dec 6, 2024

miscco Dec 6, 2024

bernhardmgruber Dec 6, 2024 •

edited

Loading

github-actions bot commented Dec 6, 2024

🟨 libcudacxx: Pass: 79%/48 | Total: 14h 02m | Avg: 17m 33s | Max: 1h 06m | Hits: 32%/4822

🟩 thrust: Pass: 100%/46 | Total: 21h 31m | Avg: 28m 04s | Max: 1h 07m | Hits: 90%/9260

🟩 cub: Pass: 100%/45 | Total: 1d 09h | Avg: 44m 57s | Max: 1h 15m | Hits: 75%/3028

🟩 cudax: Pass: 100%/26 | Total: 5h 38m | Avg: 13m 01s | Max: 19m 20s | Hits: 64%/312

🟩 cccl_c_parallel: Pass: 100%/2 | Total: 12m 27s | Avg: 6m 13s | Max: 10m 05s

🟩 python: Pass: 100%/1 | Total: 23m 53s | Avg: 23m 53s | Max: 23m 53s

👃 Inspect Changes

Modifications in project?

Modifications in project or dependencies?

🏃‍ Runner counts (total jobs: 168)

Use a more efficient enable_if_t implementation #3071

Are you sure you want to change the base?

Use a more efficient enable_if_t implementation #3071

Conversation

miscco commented Dec 6, 2024

bernhardmgruber Dec 6, 2024

Choose a reason for hiding this comment

miscco Dec 6, 2024

Choose a reason for hiding this comment

bernhardmgruber Dec 6, 2024 • edited Loading

Choose a reason for hiding this comment

github-actions bot commented Dec 6, 2024

🟨 libcudacxx: Pass: 79%/48 | Total: 14h 02m | Avg: 17m 33s | Max: 1h 06m | Hits: 32%/4822

🟩 thrust: Pass: 100%/46 | Total: 21h 31m | Avg: 28m 04s | Max: 1h 07m | Hits: 90%/9260

🟩 cub: Pass: 100%/45 | Total: 1d 09h | Avg: 44m 57s | Max: 1h 15m | Hits: 75%/3028

🟩 cudax: Pass: 100%/26 | Total: 5h 38m | Avg: 13m 01s | Max: 19m 20s | Hits: 64%/312

🟩 cccl_c_parallel: Pass: 100%/2 | Total: 12m 27s | Avg: 6m 13s | Max: 10m 05s

🟩 python: Pass: 100%/1 | Total: 23m 53s | Avg: 23m 53s | Max: 23m 53s

👃 Inspect Changes

Modifications in project?

Modifications in project or dependencies?

🏃‍ Runner counts (total jobs: 168)

Use a more efficient `enable_if_t` implementation #3071

Use a more efficient `enable_if_t` implementation #3071

bernhardmgruber Dec 6, 2024 •

edited

Loading