API review: Add Workers management APIs. (#4556) #4682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add workers spec * added checks * Per feedback - reference dom apis and example of api usage in workers * Update specs/Workers.md Co-authored-by: David Risney <[email protected]> * address feedback-2 * remove state and add activated event * minor updates to the spec --------- Co-authored-by: David Risney <[email protected]>
vickiez
reviewed
Aug 9, 2024
oldnewthing
reviewed
Aug 13, 2024
david-risney
requested changes
Aug 13, 2024
specs/Workers.md
Outdated
| ServiceWorkerManager_ = WebViewProfile.ServiceWorkerManager; | ||
| } | ||
| CoreWebView2ServiceWorkerRegistration registration = await | ||
| ServiceWorkerManager_.GetServiceWorkerRegistrationAsync(dialog.Input.Text); |
There was a problem hiding this comment.
Please fix GetServiceWorkerRegistration docs to note about URI normalization.
specs/Workers.md
Outdated
|
|
||
| if(registration != null) | ||
| { | ||
| CoreWebView2ServiceWorker worker = registration.ActiveServiceWorker; |
There was a problem hiding this comment.
Please ensure that it does: ActiveServiceWorker won't destroy until messages pumped and so on.
specs/Workers.md
Outdated
|
|
||
| if(registration != null) | ||
| { | ||
| CoreWebView2ServiceWorker worker = registration.ActiveServiceWorker; |
There was a problem hiding this comment.
If the worker instance exits the registration continues to exist.
-- NOTE this is where we stopped in the review meeting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an API review for the new Workers API.