Add spec for ProgrammaticSaveAs.md #3777
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-risney
requested changes
Sep 15, 2023
added 4 commits
September 19, 2023 09:47
Add explanations, examples. Add property 'Cancel', 'SuppressDefaultDialog'
vickiez
reviewed
Oct 2, 2023
david-risney
reviewed
Oct 2, 2023
david-risney
requested changes
Oct 2, 2023
Master-Ukulele
commented
Oct 4, 2023
oldnewthing
reviewed
Oct 4, 2023
MikeHillberg
reviewed
Oct 5, 2023
MikeHillberg
reviewed
Oct 5, 2023
FrankC-msft
reviewed
Oct 5, 2023
david-risney
reviewed
Oct 5, 2023
david-risney
approved these changes
Oct 5, 2023
Master-Ukulele
commented
Oct 6, 2023
added 2 commits
November 27, 2023 16:16
- More accurate the description for different Kind, including top-level document, subresources, wiki link. - Rewrite the sample code. The methods of add event handler were removed. In new sample code, one method will both register handler and call save as. - Add comment to address get_ContentMimeType can help the Kind selection. - Add comment to address the CoreWebView2SaveAsUIResults will help end developer know the error if API call failed.
Master-Ukulele
added
the
review completed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a review for the new Programmatic Save As API