-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update performance-guidance.md #9962
base: live
Are you sure you want to change the base?
Conversation
@azarboon : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
Learn Build status updates of commit eb62a0f: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Can you review the proposed changes? IMPORTANT: When the changes are ready for publication, adding a #label:"aq-pr-triaged" |
Rewrote it to accommodate feedbacks
@WilliamDAssafMSFT thank you for your constructive and spot-on feedbacks. Yes, I wrote those on Wikipedia to raise awareness but you are absolutely right that the doc should be more precise, actionable. I've edited it to accommodate your feedbacks. Please let me know your advice. |
Learn Build status updates of commit 6ec9beb: 💡 Validation status: suggestions
azure-sql/database/performance-guidance.md
For more details, please refer to the build report. Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. For any questions, please:
|
Learn Build status updates of commit 02c3431: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
@WilliamDAssafMSFT thanks for edits. Can you please sign it off? |
@azarboon Hi! This remains in review by a few others on the product group. Will update when ready. |
Accommodated feedback regarding monitoring tokens
Learn Build status updates of commit 417bd7c: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
@dimitri-furman thank you. I accomodated your feedback. |
@WilliamDAssafMSFT thanks for combining the two sections. It was a good idea. I've added some more insights and tips to optimize connection pooling