Fix setting default value of request.PostData of HarEntry #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erunion
reviewed
Jul 18, 2023
nsrCodes
force-pushed
the
fix-postdata-default-type
branch
from
2535062 to
d5e88ab
Compare
|
|
…ata might be undefined
filfreire
force-pushed
the
fix-postdata-default-type
branch
from
d5e88ab to
d888e39
Compare
filfreire
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since har entry is of type [src]
so
request.postDatacould have the valueundefinedThe current approach of setting the default value for this key will fail when
postDataisundefinedThis then breaks the switch case inside the prepare method because there is no optional chaining
This PR is broken into two commits. If only either one feels sufficient, the changes can be cherry-picked or both can be squashed.