fix: googletag.display errors when ad slot not in DOM #142
+32
−136
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where GPT complains if googletag.displaySlots() is called for a defined ad slot that is not yet in the DOM, i.e.
Advertising.displaySlots()
. So instead calling this method inAdvertising.setupGpt()
, we are now calling it at the end ofAdvertising.active()
.window.googletag.display(id)
for this singleid
, instead of iterating through all the slotsAdvertising.active()
gets called from theAdvertisingSlot
component, so now Advertising.displaySlots() will not fire for defined ad slots that are not yet in the DOM.