-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable aphrodite-add-style-variable-name rule in eslint-plugin-khan demo project #1095
Conversation
🦋 Changeset detectedLatest commit: e4bc789 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1095 +/- ##
=======================================
Coverage 99.85% 99.85%
=======================================
Files 97 97
Lines 1392 1392
Branches 351 358 +7
=======================================
Hits 1390 1390
Misses 1 1
Partials 1 1 Continue to review full report in Codecov by Sentry.
|
Size Change: 0 B Total Size: 4.63 kB ℹ️ View Unchanged
|
I noticed the error message could be improved, I'll land that update first and release that before setting this for review! #1096 |
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚢
Summary:
Now that the
eslint-plugin-khan
package is released with the newaphrodite-add-style-variable-name
rule, we can update the demo project to test that the rule works as expectedIssue: FEI-5952
Test plan:
Linting error
yarn lint
inpackages/eslint-plugin-khan/demo
aphrodite-add-style-variable-name
ruleHints in vs code
packages/eslint-plugin-khan/demo
in vs code (the demo project needs to be opened separately)foo.tsx
file