Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable aphrodite-add-style-variable-name rule in eslint-plugin-khan demo project #1095

Merged
merged 4 commits into from
Dec 17, 2024

Conversation

beaesguerra
Copy link
Member

@beaesguerra beaesguerra commented Dec 13, 2024

Summary:

Now that the eslint-plugin-khan package is released with the new aphrodite-add-style-variable-name rule, we can update the demo project to test that the rule works as expected

Issue: FEI-5952

Test plan:

Linting error

  • Run yarn lint in packages/eslint-plugin-khan/demo
  • Notice there is an error for the aphrodite-add-style-variable-name rule
Screenshot 2024-12-13 at 4 19 12 PM

Hints in vs code

  • Open packages/eslint-plugin-khan/demo in vs code (the demo project needs to be opened separately)
  • Open the foo.tsx file
  • Notice the linting error on the variable name when using addStyle
Screenshot 2024-12-13 at 4 22 04 PM

@beaesguerra beaesguerra self-assigned this Dec 13, 2024
Copy link

changeset-bot bot commented Dec 13, 2024

🦋 Changeset detected

Latest commit: e4bc789

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.85%. Comparing base (8f4b545) to head (e4bc789).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1095   +/-   ##
=======================================
  Coverage   99.85%   99.85%           
=======================================
  Files          97       97           
  Lines        1392     1392           
  Branches      351      358    +7     
=======================================
  Hits         1390     1390           
  Misses          1        1           
  Partials        1        1           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f4b545...e4bc789. Read the comment docs.

Copy link
Contributor

github-actions bot commented Dec 13, 2024

Size Change: 0 B

Total Size: 4.63 kB

ℹ️ View Unchanged
Filename Size
packages/wonder-stuff-core/dist/browser/es/index.js 1.85 kB
packages/wonder-stuff-sentry/dist/browser/es/index.js 1.65 kB
packages/wonder-stuff-testing/dist/browser/es/index.js 1.12 kB

compressed-size-action

@beaesguerra
Copy link
Member Author

I noticed the error message could be improved, I'll land that update first and release that before setting this for review! #1096

@beaesguerra beaesguerra marked this pull request as ready for review December 13, 2024 23:30
@khan-actions-bot khan-actions-bot requested a review from a team December 13, 2024 23:30
@khan-actions-bot
Copy link
Contributor

Gerald

Required Reviewers
  • @Khan/frontend-infra for changes to .changeset/plenty-bats-flow.md, packages/eslint-plugin-khan/demo/.eslintrc.js, packages/eslint-plugin-khan/demo/package.json, packages/eslint-plugin-khan/demo/yarn.lock

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

Copy link
Contributor

@kevinb-khan kevinb-khan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@beaesguerra beaesguerra merged commit 506ed87 into main Dec 17, 2024
8 checks passed
@beaesguerra beaesguerra deleted the update-eslint-plugin-version branch December 17, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants