Skip to content

Commit

Permalink
Deflowify wonder-stuff (#1001)
Browse files Browse the repository at this point in the history
## Summary:
We're finished the TypeScript migration so we no longer need Flow related stuff kicking around.

Issue: None

## Test plan:
- yarn test
- cd packages/eslint-plugin-khan
- yarn test

Author: kevinbarabash

Reviewers: jeresig, somewhatabstract

Required Reviewers:

Approved By: jeresig, somewhatabstract

Checks: ✅ codecov/project, ✅ Test (macos-latest, 20.x), ✅ CodeQL, ✅ Lint, typecheck, and coverage check (ubuntu-latest, 20.x), ✅ Prime node_modules cache for primary configuration (ubuntu-latest, 20.x), ✅ gerald, ⏭️  dependabot, ✅ Analyze (javascript)

Pull Request URL: #1001
  • Loading branch information
kevinbarabash authored Jan 9, 2024
1 parent d6296d4 commit 23a8585
Show file tree
Hide file tree
Showing 34 changed files with 27 additions and 1,513 deletions.
5 changes: 5 additions & 0 deletions .changeset/calm-boxes-exist.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@khanacademy/eslint-plugin": major
---

Remove Flow related rules
8 changes: 8 additions & 0 deletions .changeset/light-apes-matter.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
---
"@khanacademy/wonder-stuff-render-environment-jsdom": patch
"@khanacademy/wonder-stuff-render-server": patch
"@khanacademy/wonder-stuff-server": patch
"@khanacademy/wonder-stuff-core": patch
---

Update comments to no longer reference Flow
9 changes: 4 additions & 5 deletions .codecov.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ coverage:

status:
project:
default: on
default: true
patch:
default: off
changes:
Expand All @@ -14,14 +14,13 @@ coverage:
comment:
layout: "header, reach, diff, flags, files, footer"
behavior: default
require_changes: no
require_base: no
require_head: yes
require_changes: false
require_base: false
require_head: true

ignore:
- "build-settings/*.js"
- "utils/*.js"
- "packages/**/dist/index.js"
- "packages/**/types/**/*.ts"
- "packages/**/examples/**/*.ts"
- "packages/**/*.flowtest.js"
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -44,11 +44,11 @@ We love code reviews. If there are open pull requests, please feel free to revie

#### Automated

To ensure code quality, we use prettier, flow, eslint, and jest. These are all executed automatically on commit, so don't worry if you forget to run them before you commit. They are also executed when you submit, edit, or push to a pull request to ensure the contribution meets our code quality standard.
To ensure code quality, we use prettier, TypeScript, eslint, and jest. These are all executed automatically on commit, so don't worry if you forget to run them before you commit. They are also executed when you submit, edit, or push to a pull request to ensure the contribution meets our code quality standard.

To execute these operations outside of a pull request or commit operation, you can use `yarn`.

- `yarn flow`
- `yarn typecheck`
- `yarn lint`
- `yarn test`

Expand Down
5 changes: 0 additions & 5 deletions packages/eslint-plugin-khan/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,6 @@ eslint plugin with our set of custom rules for various things

## Rules

- [khan/flow-array-type-style](docs/flow-array-type-style.md)
- [khan/flow-exact-props](docs/flow-exact-props.md)
- [khan/flow-exact-state](docs/flow-exact-state.md)
- [khan/flow-no-one-tuple](docs/flow-no-one-tuple.md)
- [khan/imports-requiring-flow](docs/imports-requiring-flow.md)
- [khan/jest-async-use-real-timers](docs/jest-async-use-real-timers.md)
- [khan/jest-enzyme-matchers](docs/jest-enzyme-matchers.md)
- [khan/react-no-method-jsx-attribute](docs/react-no-method-jsx-attribute.md)
Expand Down
1 change: 0 additions & 1 deletion packages/eslint-plugin-khan/babel.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
// NOTE(kevinb): This should only be used by eslint-plugin-khan
module.exports = {
presets: [
"@babel/preset-flow",
[
"@babel/preset-env",
{
Expand Down
29 changes: 0 additions & 29 deletions packages/eslint-plugin-khan/docs/flow-array-type-style.md

This file was deleted.

44 changes: 0 additions & 44 deletions packages/eslint-plugin-khan/docs/flow-exact-props.md

This file was deleted.

38 changes: 0 additions & 38 deletions packages/eslint-plugin-khan/docs/flow-exact-state.md

This file was deleted.

33 changes: 0 additions & 33 deletions packages/eslint-plugin-khan/docs/flow-no-one-tuple.md

This file was deleted.

107 changes: 0 additions & 107 deletions packages/eslint-plugin-khan/docs/imports-requiring-flow.md

This file was deleted.

1 change: 0 additions & 1 deletion packages/eslint-plugin-khan/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
"devDependencies": {
"@babel/eslint-parser": "^7.22.15",
"@babel/preset-env": "^7.23.2",
"@babel/preset-flow": "^7.22.15",
"@babel/preset-react": "^7.22.15",
"@swc-node/register": "^1.6.8",
"@swc/core": "^1.3.93",
Expand Down
44 changes: 0 additions & 44 deletions packages/eslint-plugin-khan/src/rules/flow-array-type-style.js

This file was deleted.

Loading

0 comments on commit 23a8585

Please sign in to comment.