Skip to content

Commit

Permalink
QoL: Turn on automatic commit of changesets (#1097)
Browse files Browse the repository at this point in the history
## Summary:

The `changesets` tooling supports a configuration option that causes `yarn changeset` to automatically add and commit the created file ([docs](https://github.com/changesets/changesets/blob/main/docs/config-file-options.md#commit-boolean-or-module-path-as-a-string-or-a-tuple-like-modulepath-string-options-any)).  

NOTE: If there are existing changes in your local repo, these changes _will not_ be included in the commit (so it's safe to run `yarn changeset` no matter the state of your repo).

There are PRs in other Khan Academy repos that use the Changesets tooling. We'll only land this if there's consensus across these other repos too:

  * #1097 (this PR)
  * Khan/wonder-blocks#2394
  * Khan/perseus#2008

Issue: "none"

## Test plan:

`yarn changeset` 
Fill in the details 
Once complete, run `git log` and you will see that the changeset entry you created has been added and committed to git - all that's left is to create the PR!

Author: jeremywiebe

Reviewers: jeresig, somewhatabstract

Required Reviewers:

Approved By: jeresig

Checks: ✅ codecov/project, ✅ Test (macos-latest, 20.x), ✅ Test (macos-latest, 20.x), ✅ Lint, typecheck, and coverage check (ubuntu-latest, 20.x), ✅ Lint, typecheck, and coverage check (ubuntu-latest, 20.x), ✅ Prime node_modules cache for primary configuration (ubuntu-latest, 20.x), ⏭️  gerald, ⏭️  gerald, ✅ Prime node_modules cache for primary configuration (ubuntu-latest, 20.x), ✅ Test (macos-latest, 20.x), ✅ CodeQL, ✅ Lint, typecheck, and coverage check (ubuntu-latest, 20.x), ✅ gerald, ✅ Prime node_modules cache for primary configuration (ubuntu-latest, 20.x), ✅ Analyze (javascript), ⏭️  dependabot

Pull Request URL: #1097
  • Loading branch information
jeremywiebe authored Dec 16, 2024
1 parent 6e50d0d commit 0073ccb
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .changeset/config.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"$schema": "https://unpkg.com/@changesets/[email protected]/schema.json",
"changelog": "@changesets/cli/changelog",
"commit": false,
"commit": true,
"linked": [],
"access": "public",
"baseBranch": "main",
Expand All @@ -10,4 +10,4 @@
"___experimentalUnsafeOptions_WILL_CHANGE_IN_PATCH": {
"updateInternalDependents": "always"
}
}
}
2 changes: 2 additions & 0 deletions .changeset/odd-mirrors-dance.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
---
---

0 comments on commit 0073ccb

Please sign in to comment.