Use LabeledField in other component stories #2400
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 98.8 kB ℹ️ View Unchanged
|
A new build was pushed to Chromatic! 🚀https://5e1bf4b385e3fb0020b7073c-avxcxlgzkg.chromatic.com/ Chromatic results:
|
beaesguerra
force-pushed
the
wb-1783-use-lf-in-stories
branch
from
f636e4b to
f0b2280
Compare
|
beaesguerra
force-pushed
the
wb-1783-use-lf-in-stories
branch
2 times, most recently
from
b9e17df to
d7cfbf6
Compare
beaesguerra
force-pushed
the
wb-1783-use-lf-in-stories
branch
from
d7cfbf6 to
af12901
Compare
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
npm Snapshot: Published🎉 Good news!! We've packaged up the latest commit from this PR (d75dafe) and published all packages with changesets to npm. You can install the packages in webapp by running: ./services/static/dev/tools/deploy_wonder_blocks.js --tag="PR2400"Packages can also be installed manually by running: yarn add @khanacademy/wonder-blocks-<package-name>@PR2400 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Use LabeledField in other component stories
Issue: WB-1783
Test plan:
Verify stories for the following components:
?path=/docs/packages-dropdown-singleselect--docs)?path=/docs/packages-dropdown-multiselect--docs)?path=/docs/packages-form-textarea--docs)?path=/docs/packages-form-textarea-all-variants--docs)?path=/docs/packages-form-textfield--docs)?path=/docs/packages-form-textfield-all-variants--docs)?path=/docs/packages-searchfield--docs)?path=/docs/packages-searchfield-all-variants--docs)Note: This addresses Storybook a11y issues related to form fields and labels. There are some stories that focus on the form field without the label so those warnings will need to be handled separately!