Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix half-measures #156

Merged
merged 5 commits into from
Sep 2, 2021
Merged

fix half-measures #156

merged 5 commits into from
Sep 2, 2021

Conversation

cscherrer
Copy link
Collaborator

@cscherrer cscherrer commented Sep 2, 2021 •
edited
Loading

TODO

  • Add tests

@cscherrer cscherrer linked an issue Sep 2, 2021 that may be closed by this pull request
HalfNormal constructor is broken #155
Closed
@codecov
Copy link

codecov bot commented Sep 2, 2021 •
edited
Loading

Codecov Report

Merging #156 (d8a7c55) into master (9b3f489) will increase coverage by 1.32%.
The diff coverage is 28.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #156      +/-   ##
==========================================
+ Coverage   33.81%   35.13%   +1.32%     
==========================================
  Files          29       29              
  Lines         556      555       -1     
==========================================
+ Hits          188      195       +7     
+ Misses        368      360       -8
Impacted Files Coverage Δ
src/parameterized/cauchy.jl 30.76% <ø> (+23.07%) ⬆️
src/parameterized/laplace.jl 10.00% <ø> (+0.90%) ⬆️
src/parameterized/normal.jl 20.68% <ø> (+3.44%) ⬆️
src/parameterized/studentt.jl 53.33% <28.57%> (+20.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b3f489...d8a7c55. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2021

Package name latest stable
Mitosis.jl
Soss.jl

@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2021

Package name latest stable
Mitosis.jl
Soss.jl

@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2021

Package name latest stable
Mitosis.jl
Soss.jl

@cscherrer cscherrer requested a review from sethaxen September 2, 2021 22:03
@cscherrer
Copy link
Collaborator Author

@sethaxen I think it's fixed, but the fix requires MeasureBase v0.3.7, which is pending registration. I assume we'll need to re-run the tests once that's ready.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2021

Package name latest stable
Mitosis.jl
Soss.jl

@sethaxen sethaxen closed this Sep 2, 2021
@sethaxen sethaxen reopened this Sep 2, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2021

Package name latest stable
Mitosis.jl
Soss.jl

sethaxen
sethaxen approved these changes Sep 2, 2021
View reviewed changes
Copy link
Collaborator

@sethaxen sethaxen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending tests passing, this PR LGTM. I did have some extra-PR questions.

src/parameterized/studentt.jl Show resolved Hide resolved
test/runtests.jl Outdated Show resolved Hide resolved
@cscherrer cscherrer mentioned this pull request Sep 2, 2021
Open
@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2021

Package name latest stable
Mitosis.jl
Soss.jl

@cscherrer cscherrer merged commit edf7d41 into master Sep 2, 2021
@cscherrer cscherrer deleted the fix-half branch September 2, 2021 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sethaxen sethaxen sethaxen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HalfNormal constructor is broken
2 participants
@cscherrer @sethaxen