Remove non-existent property

[inkydragon]

@staticfloat

tl; dr

1. rm if branch in Base.getproperty(::SHA2_CTX, )
2. Make function getproperty(::SHA2_CTX, ) and function getproperty(::SHA3_CTX, ) error messages consistent
3. rm trailing spaces in test
4. add more test for Base.getproperty

1. rm if branch

Property W only exists in SHA1_CTX, not exists in <:SHA2_CTX.

SHA.jl/src/types.jl

Lines 10 to 15 in 918aff1

	mutable struct SHA1_CTX <: SHA_CTX
	state::Array{UInt32,1}
	bytecount::UInt64
	buffer::Array{UInt8,1}
	W::Array{UInt32,1}
	end

SHA.jl/src/types.jl

Lines 18 to 22 in 918aff1

	mutable struct SHA2_224_CTX <: SHA2_CTX
	state::Array{UInt32,1}
	bytecount::UInt64
	buffer::Array{UInt8,1}
	end

2. error msg

SHA.jl/src/types.jl

Line 52 in 918aff1

error("SHA2_CTX has no field ", fieldname)

SHA.jl/src/types.jl

Line 100 in 918aff1

error("type ", typeof(ctx), " has no field ", fieldname)

3. more test

https://app.codecov.io/gh/JuliaCrypto/SHA.jl/blob/master/src/types.jl

---

And furthermore, maybe we can delete the entire Base.getproperty(::Union{SHA2_CTX, SHA3_CTX}, ...).

[inkydragon]

One question: is this a bug?

SHA.jl/src/types.jl

Line 123 in 918aff1

state_type(::Type{SHA3_CTX}) = UInt64

-state_type(::Type{SHA3_CTX}) = UInt64
+state_type(::Type{T}) where {T<:SHA3_CTX} = UInt64

[staticfloat]

This all looks good to me; and yes, I believe that SHA3_CTX should be subtyped like you suggest.

[staticfloat]

Personally, I don't think the getproperty() stuff is that useful, so I'd be okay with even just removing it all. I'm not sure it's actually used anywhere. :P

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (068f85d) 98.14% compared to head (967a110) 98.96%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##           master      #75      +/-   ##
==========================================
+ Coverage   98.14%   98.96%   +0.82%     
==========================================
  Files           9        9              
  Lines         484      482       -2     
==========================================
+ Hits          475      477       +2     
+ Misses          9        5       -4     

Files	Coverage Δ
src/types.jl	100.00% <100.00%> (+5.00%)	⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[inkydragon]

Ready for merge.

Personally, I don't think the getproperty() stuff is that useful, so I'd be okay with even just removing it all.

We may need to check the type stability and performance of each API after removing getproperty.
I will open a new issue to track this. (#77)

[staticfloat]

This appears to have slipped through the cracks, I'm sorry. Can you resolve the conflicts?

[staticfloat]

Thanks for taking that over the finish line, @inkydragon !