-
-
Notifications
You must be signed in to change notification settings - Fork 670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Clarify further remote module version bumps with ITK minor releases #4769
base: master
Are you sure you want to change the base?
DOC: Clarify further remote module version bumps with ITK minor releases #4769
Conversation
Clarify further remote module major version bumps with ITK minor releases.
Why is this preferred over more specific pinning of the package install requirements to something like "itk~=5.4.0"? |
Thanks for integrating Matt's comment to the documentation. I still don't really understand why the major version of the remote module should be bumped but not the major version of ITK but this is most likely due to a lack of knowledge on my side. |
My suspicion is that this line is not correct: and should be something like "itk~=5.4.0" to only allow the ITK patch version to very. |
InsightSoftwareConsortium/ITKIsotropicWavelets#159 and #4748 (comment). |
While we attempt to maintain API compatibility between ITK minor releases, the | ||
ABI generally changes. This can be due to features and bug fixes in the ITK | ||
source code, but there are also usually build system changes that cause ABI | ||
changes. Thus, remote module versions should be bumped into a new major |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, While ITK's main Python packages do not follow semantic versioning, it is recommended that remote module bump the major version when the minor version of ITK change to follow semantic versioning best practices.
Is that clearer?
Perhaps it is clearer to have remote module package versions follow their own semantic versioning path, i.e. bump the minor version when bumping the |
This has my preference but it might be because I didn't get the explanation... |
I initially thought a remote module update should be considered a breaking change because it forces an |
Does everyone agree ( 👍 👎 )that we should recommend bumping the minor version on remote module packages with a new |
Folks, please, go ahead and edit the change and push force so that it reflects better what the policy should be so that the policy and the underlying rationale are clear onwards. |
The below will need to be changed in accordance to what is adopted here: as well as the logic in the script. |
Clarify further remote module major version bumps with ITK minor releases.
PR Checklist