Timeout#Cancel(): allow waiting for the own coroutine to finish #10250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Al2Klimov
added
the
core/quality
julianbrost
reviewed
Nov 25, 2024
| { | ||
| Ptr keepAlive (this); | ||
|
|
||
| m_Cancelled.store(false); | ||
| m_Timer.expires_from_now(std::move(timeoutFromNow)); | ||
|
|
||
| IoEngine::SpawnCoroutine(executor, [this, keepAlive, onTimeout](boost::asio::yield_context yc) { | ||
| auto setDone (Shared<Defer>::Make([this, keepAlive] { m_Done.Set(); })); |
There was a problem hiding this comment.
What's the reason for this shared pointer instead of doing this inside the lambda just below?
Comment on lines
+157
to
+161
| /** | ||
| * Cancels the timeout and waits for the own coroutine to finish. | ||
| * | ||
| * @param yc Yield Context for ASIO | ||
| */ |
There was a problem hiding this comment.
On its own, this doc comment misses context, i.e. there's no other doc comment that mentions a coroutine.
I think it would be more helpful if it instead stated the effects. Like that it waits for the involved resources to be destroyed, which includes waiting for the callback if it was already triggered.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Especially useful not to have to drag shared pointers around in the callback.