feat: changes to support motd #385
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
October 12, 2023 15:30
Aerex
reviewed
Dec 21, 2023
| @@ -9,6 +9,8 @@ import ( | |||
| "github.com/IBM-Cloud/ibm-cloud-cli-sdk/bluemix" | |||
| "github.com/IBM-Cloud/ibm-cloud-cli-sdk/bluemix/configuration" | |||
| "github.com/IBM-Cloud/ibm-cloud-cli-sdk/bluemix/models" | |||
|
|
|||
| // "github.com/IBM-Cloud/ibm-cloud-cli-sdk/plugin" | |||
go.mod
Outdated
| @@ -1,19 +1,20 @@ | |||
| module github.com/IBM-Cloud/ibm-cloud-cli-sdk | |||
|
|
|||
| go 1.20 | |||
| go 1.19 | |||
There was a problem hiding this comment.
Let move the go version to match what is on the core CLI
bluemix/motd/motd.go
Outdated
| return false | ||
| } | ||
|
|
||
| func CheckMessageOfTheDay(client *rest.Client, config core_config.ReadWriter, pluginConfig plugin.PluginConfig, modURL string, ui terminal.UI, version string) { |
There was a problem hiding this comment.
The version parameter is never used in this method. Lets remove it.
|
So sorry about the delay on this response @Aerex . I think you made these comments before I left for end-of-year vacation, and I was oblivious to them until the issue became re-ranked to a higher priority just recently. I made straightforward corrections to 3/4 of your comments and asked a followup about the last one. |
added 2 commits
July 11, 2024 09:31
Co-authored-by: Aerex <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PR contains code to support retrieval of and recordkeeping of update frequency for a "message of the day" similarly to how it works in the core CLI program. There are some assumptions about replicating the entries for MotD that appear in the core program's configuration in plugin configuration files (adding a key "MessageOfTheDayTime" and one key for the location on COS from where the MotD payload can be fetched); this may change later in the review process.