Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

picsart 1.0.0 #201359

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

picsart 1.0.0 #201359

wants to merge 1 commit into from

Conversation

arammkhitaryan
Copy link

Add Picsart Formula

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Add Picsart Formula
@github-actions github-actions bot added autosquash Automatically squash pull request commits according to Homebrew style. new formula PR adds a new formula to Homebrew/homebrew-core missing license Formula has a missing license which should be added labels Dec 16, 2024
@arammkhitaryan arammkhitaryan changed the title Add Picsart Formula picsart 1.0.0 Dec 16, 2024
Copy link
Contributor

Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.

license "MIT"

def install
system "./configure", "--prefix=#{prefix}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a pure javascript project and couldn't found any configure script.

@SMillerDev
Copy link
Member

Seeing the fact that this doesn't pass any of the CI checks and generally seems to be wrong I suggest we reject this outright. Especially since the docs already mention:

We frown on authors submitting their own work unless it is very popular.

https://docs.brew.sh/Acceptable-Formulae#niche-or-self-submitted-stuff:~:text=We%20frown%20on%20authors%20submitting%20their%20own%20work%20unless%20it%20is%20very%20popular.

@chenrui333 chenrui333 added the notability Project is not notable enough for inclusion label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosquash Automatically squash pull request commits according to Homebrew style. missing license Formula has a missing license which should be added new formula PR adds a new formula to Homebrew/homebrew-core notability Project is not notable enough for inclusion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants